-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{AKS} Add backward compatibility to cli #4047
Conversation
AKS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/azp where |
Azure DevOps orgs getting events for this repository: |
/azp help |
Supported commands
See additional documentation. |
/azp list |
CI/CD Pipelines for this repository: |
Please add descriptions of these changes in history note. If you need to upgrade extension version to release these changes, please modify |
@@ -51,7 +51,6 @@ def load_command_table(self, _): | |||
with self.command_group('aks', managed_clusters_sdk, client_factory=cf_managed_clusters) as g: | |||
g.custom_command('kollect', 'aks_kollect') | |||
g.custom_command('kanalyze', 'aks_kanalyze') | |||
g.custom_command('browse', 'aks_browse') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FumingZhang If deleting this command will cause breaking change to the user, please mark it as [BREAKING CHANGE]
in the history notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @zhoxing-ms, I suppose user should always have azure-cli installed before using aks-preview and if a command is not implemented in azure-cli-extensions, it will fall back to the implementation in azure-cli.
For this case, the implementation of aks browse
is basically the same in azure-cli and azure-cli-extensions (actually a little bit more logic in azure-cli), and after removing this command declaration from the extension side, when aks browse
is executed, the implementation in azure-cli will be used.
As I explained above, the changes in this PR should not introduce breaking changes that users can detect. The command |
This checklist is used to make sure that common guidelines for a pull request are followed.
aks browse
.--edge-zone
.General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.json
automatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json
.