Start and stop Azure Spring Cloud service instance #4033
Conversation
|
spring cloud |
|
Could you add some tests for those new changes? |
|
Please address those CI issues |
|
@zhoxing-ms I have resolved all the CI issues and add some tests for new feature, please help review, thanks! |
src/spring-cloud/HISTORY.md
Outdated
| 2.11.1 | ||
| ----- | ||
| * Add support for Diagnostic Operation. Heap dump: 'spring-cloud app deployment generate-heap-dump'. Thread Dump: 'spring-cloud app deployment generate-thread-dump'. JFR: 'spring-cloud app deployment start-jfr' | ||
|
|
||
| 2.11.1 | ||
| ----- | ||
| * Add support for public certificate crud, source could be either key vault or local file | ||
| * Application could load public certificate by using argument `--loaded_public_certificate_file` in batch or | ||
| * Application could load public certificate by using argument `--loaded_public_certificate_file` in batch or | ||
| directly using `spring-cloud app append-loaded-public-certificate` one by one | ||
| * Add support to list all apps which have loaded the certificate `spring-cloud certificate list-reference-app` |
There was a problem hiding this comment.
Here are two descriptions for version 2.11.1, which are repeated
There was a problem hiding this comment.
Seems we have a wrong version in the previous commit, I updated the previous one from 2.11.1 to 2.11.2 and made the latest version 2.11.3, thus the version in setup.py is updated from 2.11.1 to 2.11.3.
src/spring-cloud/setup.py
Outdated
| VERSION = '2.11.1' | ||
| VERSION = '2.11.3' |
There was a problem hiding this comment.
Why is the latest version of HISTORY.md 2.11.2, but the version here is 2.11.3?
There was a problem hiding this comment.
If the version of 2.11.2 has not been released before, it is recommended not to skip the release of version 2.11.2. Maybe we can consider merging the history of two 2.11.1 version, and release this PR as version 2.11.2
There was a problem hiding this comment.
That's because we missed 2.11.2 in HISTORY.md in the last commit.
There was a problem hiding this comment.
If the version of
2.11.2has not been released before, it is recommended not to skip the release of version2.11.2. Maybe we can consider merging the history of two2.11.1version, and release this PR as version2.11.2
Make sense, updated to 2.11.2 now. Please help to check.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.