add dnc rp cli commands #3433
Merged
add dnc rp cli commands #3433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dnc |
kairu-ms
reviewed
Jun 3, 2021
kairu-ms
reviewed
Jun 4, 2021
kairu-ms
reviewed
Jun 4, 2021
| @@ -67,8 +61,8 @@ def load_arguments(self, _): | |||
| c.argument('cluster_root_ca', type=str, help='RootCA certificate of kubernetes cluster base64 encoded') | |||
| c.argument('api_server_endpoint', type=str, help='K8s APIServer url. Either one of apiServerEndpoint or ' | |||
| 'privateLinkResourceId can be specified') | |||
| c.argument('private_link_resource_id', type=str, help='private link arm resource id. Either one of ' | |||
| 'apiServerEndpoint or privateLinkResourceId can be specified') | |||
| c.argument('private_link_resource_id', options_list=['--privlinkresourceid'], type=str, help='private link arm ' | |||
There was a problem hiding this comment.
I'm sorry I am not following, I currently have it like this - what split are we trying to accomplish?
- where:
group: .*
parameter: privateLinkResourceId
alias:
- privLinkResourceId
There was a problem hiding this comment.
Can you try the following configuration?
- where:
group: .*
parameter: privateLinkResourceId
alias:
- priv_link_resource_id
kairu-ms
reviewed
Jun 7, 2021
| g.custom_show_command('show', 'dnc_delegated_subnet_service_show') | ||
| g.custom_command('create', 'dnc_delegated_subnet_service_create', supports_no_wait=True) | ||
| g.custom_command('delete', 'dnc_delegated_subnet_service_delete', supports_no_wait=True, confirmation=True) | ||
| g.custom_command('patch-detail', 'dnc_delegated_subnet_service_patch_detail', supports_no_wait=True) |
There was a problem hiding this comment.
Please use "update" instead of "patch-detail"
kairu-ms
approved these changes
Jun 9, 2021
|
@aegal Please rebase your branch to fix ci issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.