{Script} Add retry in get_whl_from_url and only verify latest version of an extension #2987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Script |
fengzhou-msft
changed the title
jiasli
reviewed
Feb 9, 2021
scripts/ci/test_index.py
Outdated
| @@ -21,6 +21,10 @@ | |||
|
|
|||
| from util import get_ext_metadata, get_whl_from_url, get_index_data, verify_dependency | |||
|
|
|||
| # Some extensions are published through manually submitted PRs and the latest version may not be in the end of | |||
| # the version list in index.json. Let's just test all versions for these extensions. | |||
| EXTS_TEST_ALL_VERSIONS = {'azure-cli-ml', 'alias', 'azure_iot'} | |||
There was a problem hiding this comment.
Maybe we can sort all versions and only test the latest one?
There was a problem hiding this comment.
Python's built-in function max supports a custom key extraction function and we can use packaging.version for version comparison.
There was a problem hiding this comment.
updated with picking a max version so the order of versions does not matter now.
jiasli
reviewed
Feb 9, 2021
jiasli
reviewed
Feb 9, 2021
scripts/ci/test_index.py
Outdated
| item['sha256Digest'], | ||
| item['filename'])) | ||
| # only test the latest version | ||
| item = max(exts, key=lambda ext: LooseVersion(ext['metadata']['version'])) |
There was a problem hiding this comment.
distutils.version.LooseVersion is legacy and conformant only to the superseded PEP 386 (by PEP 440). Perhaps we can migrate to the latest packaging.version.
There was a problem hiding this comment.
LooseVersion doesn't comply with PEP 440 and can't handle pre-release versions.
>>> from distutils.version import LooseVersion, StrictVersion
>>> StrictVersion('1.0.0a1') < StrictVersion('1.0.0')
True
>>> LooseVersion('1.0.0a1') < LooseVersion('1.0.0')
False
fengzhou-msft
commented
Feb 9, 2021
jiasli
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To mitigate the increasing failures in
Verify Extensions IndexCI task recently.This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.