Add warning message and unset active deployment operation #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yungezz
reviewed
Dec 22, 2020
| @@ -48,6 +48,8 @@ def load_command_table(self, _): | |||
| g.custom_command('show-deploy-log', 'app_get_build_log') | |||
| g.custom_command('set-deployment', 'app_set_deployment', | |||
| supports_no_wait=True) | |||
| g.custom_command('unset-deployment', 'app_unset_deployment', | |||
There was a problem hiding this comment.
the commands quite confusing:
az spring-cloud app deployment create
az spring-cloud app set-deployment
az spring-cloud app unset-deployment
To consistent, why not
az spring-cloud app deployment set --type <production/non-production>?
There was a problem hiding this comment.
Since they have different parameters, and "set-deployment" has been used by customers, hope not to introduce breaking change.
|
Please fix linter error and rerecord tests. |
fengzhou-msft
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.