[Communication] 0.1.0 Init #2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haroldrandom
changed the title
|
Communication |
haroldrandom
force-pushed
the
spool-communication
branch
from
60cb337 to
dfad3c3
Compare
added 2 commits
November 5, 2020 09:13
Juliehzl
reviewed
Nov 12, 2020
Juliehzl
reviewed
Nov 12, 2020
Juliehzl
reviewed
Nov 12, 2020
Juliehzl
reviewed
Nov 12, 2020
src/communication/README.md
Outdated
| az communication communication-service create --name "MyCommunicationResource" --location "Global" \ | ||
| --data-location "United States" --resource-group "MyResourceGroup" | ||
|
|
||
| az communication communication-service wait --created --name "{myCommunicationService}" --resource-group "{rg}" |
There was a problem hiding this comment.
If you want to show wait command usage here, please add --no wait in create command.
Juliehzl
reviewed
Nov 12, 2020
Juliehzl
reviewed
Nov 12, 2020
Juliehzl
reviewed
Nov 12, 2020
Juliehzl
reviewed
Nov 12, 2020
Comment on lines
79
to
96
| helps['communication service list-key'] = """ | ||
| type: command | ||
| short-summary: "Get the access keys of the CommunicationService resource." | ||
| examples: | ||
| - name: List keys | ||
| text: |- | ||
| az communication service list-key --name "MyCommunicationResource" --resource-group "MyResourceGroup" | ||
| """ | ||
|
|
||
| helps['communication service regenerate-key'] = """ | ||
| type: command | ||
| short-summary: "Regenerate CommunicationService access key. PrimaryKey and SecondaryKey cannot be regenerated at \ | ||
| the same time." | ||
| examples: | ||
| - name: Regenerate key | ||
| text: |- | ||
| az communication service regenerate-key --name "MyCommunicationResource" --key-type "Primary" \ | ||
| --resource-group "MyResourceGroup" |
There was a problem hiding this comment.
what about adding these commands in one new command group like az storage account keys?
Juliehzl
reviewed
Nov 12, 2020
Juliehzl
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close https://github.com/Azure/azure-cli-pr/issues/99
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.