Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information in command conflict exception message when building extension command tree #2533

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

fengzhou-msft
Copy link
Member

@fengzhou-msft fengzhou-msft commented Oct 16, 2020

Now the log will show messages like this in case of conflicts:

Processing storage-blob-preview
...
Exception: Key: show already exists in storage-preview. 2 extensions cannot have the same command!

Now we know that storage-blob-preview and storage-preview have the same command ending with show. By searching the log message, we are able to find the duplicate command is az storage account management-policy show.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/fengzhou-msft/azure-cli-extensions.git@ext_cmd_tree_update#subdirectory=src/$EXT&egg=$EXT"

@fengzhou-msft fengzhou-msft merged commit ff30c8e into Azure:master Oct 16, 2020
@fengzhou-msft fengzhou-msft deleted the ext_cmd_tree_update branch October 16, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants