Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ai-did-you-mean-this] Fix ambiguous --que in test #2332

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

fengzhou-msft
Copy link
Member

After adding --query-examples option in core, one test failed in option prefix match:
ambiguous option: --que could match --query, --query-examples

Use the full matched --query to fix it.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/fengzhou-msft/azure-cli-extensions.git@fix_ai_test#subdirectory=src/$EXT&egg=$EXT"

@fengzhou-msft fengzhou-msft changed the title fix ambiguous --que [ai-did-you-mean-this] Fix ambiguous --que in test Sep 10, 2020
@yungezz
Copy link
Member

yungezz commented Sep 10, 2020

cc @christopher-o-toole

@yonzhan yonzhan requested a review from jiasli September 10, 2020 04:41
@fengzhou-msft fengzhou-msft merged commit ed68d69 into Azure:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants