Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating dev-spaces-preview extension to honor azds commands update #196

Merged
merged 5 commits into from
Jun 1, 2018
Merged

Updating dev-spaces-preview extension to honor azds commands update #196

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bfbfa25
Updating dev-spaces-preview extension to honor azds commands update
saurabsa May 30, 2018
d297c91
Adding update option to force install the newer version of azds tool
saurabsa Jun 1, 2018
ea8397c
Update remove command
saurabsa Jun 1, 2018
966a16a
Index Update
saurabsa Jun 1, 2018
a4da4c1
Merge branch 'master' into saurabsa/UpdateDevSpaces
saurabsa Jun 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/dev-spaces-preview/azext_dev_spaces_preview/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ def ads_use_dev_spaces(cluster_name, resource_group_name, space_name='default',

from subprocess import PIPE
retCode = subprocess.call(
[azds_cli, 'resource', 'select', '-n', cluster_name, '-g', resource_group_name],
[azds_cli, 'controller', 'select', '--name', cluster_name, '--resource-group', resource_group_name],
stderr=PIPE)
if retCode != 0:
retCode = subprocess.call(
[azds_cli, 'resource', 'create', '--aks-name', cluster_name, '--aks-resource-group',
[azds_cli, 'controller', 'create', '--target-name', cluster_name, '--target-resource-group',
resource_group_name, '--name', cluster_name, '--resource-group', resource_group_name],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This passes resource_group_name for --target-resource-group. Do we want to support creating the Controller in a different resource group than the cluster? If so, we'll need to introduce a target_resource_group_name param to pass in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, this is the spec for az cli extension we have for the use and remove command. We can update this once we have the use and remove command in azds cli. @stepro Would you like to comment on this one?

universal_newlines=True)
if retCode != 0:
Expand Down
2 changes: 1 addition & 1 deletion src/dev-spaces-preview/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

from setuptools import setup, find_packages

VERSION = "0.1.2"
VERSION = "0.1.3"

CLASSIFIERS = [
'Development Status :: 4 - Beta',
Expand Down
8 changes: 4 additions & 4 deletions src/index.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,9 +326,9 @@
],
"dev-spaces-preview": [
{
"filename": "dev_spaces_preview-0.1.2-py2.py3-none-any.whl",
"sha256Digest": "84d0470bb45cee94f62580927dc5ed2ab5be9e110ce8f836153e277f7547e012",
"downloadUrl": "https://azuredevspacestools.blob.core.windows.net/azdssetup/LKS/dev_spaces_preview-0.1.2-py2.py3-none-any.whl",
"filename": "dev_spaces_preview-0.1.3-py2.py3-none-any.whl",
"sha256Digest": "843043db63a2478d52306ff2f9dda1adf680af7e43be49ded8b5b5725b26de81",
"downloadUrl": "https://azuredevspacestools.blob.core.windows.net/azdssetup/LKS/dev_spaces_preview-0.1.3-py2.py3-none-any.whl",
"metadata": {
"azext.isPreview": true,
"azext.minCliCoreVersion": "2.0.32",
Expand Down Expand Up @@ -367,7 +367,7 @@
"metadata_version": "2.0",
"name": "dev-spaces-preview",
"summary": "Dev Spaces provides a rapid, iterative Kubernetes development experience for teams.",
"version": "0.1.2"
"version": "0.1.3"
}
}
],
Expand Down