-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aks-preview] Support updating an existing AAD-Integrated cluster to the new AKS-managed AAD experience #1898
Conversation
aks-preview |
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bingosummer , is this PR related to #1887 ? #1887 is waiting for 2020-06-01 version published. Does this also have that dependency ?
This PR doesn't need the 2020-06-01 version. But it also need to wait for this week's release. I'll update the PR then. |
…naged AAD experience
@arrownj Ready for review. @weinong @karataliu @zqingqing1 Please help review. Thanks! |
Hi @bingosummer , the code is good to me, please ping me when you think it is ready to merge. And don't forget solve the code conflict. |
@arrownj It's ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
any blockers to merge this? |
No blockers. The AKS RP changes have rolled out. @arrownj Please help merge the PR. |
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.json
automatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json
.