Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aks-preview] Support updating an existing AAD-Integrated cluster to the new AKS-managed AAD experience #1898

Merged
merged 5 commits into from
Jun 24, 2020

Conversation

bingosummer
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 17, 2020

aks-preview

@yonzhan yonzhan requested a review from qwordy June 17, 2020 11:09
@yungezz yungezz assigned arrownj and unassigned yungezz Jun 17, 2020
src/aks-preview/setup.py Outdated Show resolved Hide resolved
Copy link
Contributor

@arrownj arrownj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bingosummer , is this PR related to #1887 ? #1887 is waiting for 2020-06-01 version published. Does this also have that dependency ?

@bingosummer
Copy link
Member Author

Hi @bingosummer , is this PR related to #1887 ? #1887 is waiting for 2020-06-01 version published. Does this also have that dependency ?

This PR doesn't need the 2020-06-01 version. But it also need to wait for this week's release. I'll update the PR then.

@bingosummer
Copy link
Member Author

@arrownj Ready for review.

@weinong @karataliu @zqingqing1 Please help review. Thanks!

@arrownj
Copy link
Contributor

arrownj commented Jun 23, 2020

Hi @bingosummer , the code is good to me, please ping me when you think it is ready to merge. And don't forget solve the code conflict.

@bingosummer
Copy link
Member Author

@arrownj It's ready to merge.

Copy link
Member

@zqingqing1 zqingqing1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@palma21
Copy link
Member

palma21 commented Jun 24, 2020

any blockers to merge this?

@bingosummer
Copy link
Member Author

any blockers to merge this?

No blockers. The AKS RP changes have rolled out.

@arrownj Please help merge the PR.

@arrownj arrownj merged commit a6a8834 into Azure:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants