-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swagger-to-cli-automation-config #1537
Conversation
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
|
add to S168 |
"version": "3.0.6198", | ||
"sdkrel:output-folder":".", | ||
"clear-output-folder":"false" | ||
"version": "3.0.6271", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it on purpose to remove output-folder
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. the latest @autorest/az package 1.3.2 use --azure-cli-extension-folder instead of --output-folder to specify the output location. @autorest/az will add the src/extension-name.
it also allows the --clear-output-folder except manual folder.
Futher info can found here.
https://github.com/Azure/autorest.az/blob/master/doc/faq.md#what-would-the-clear-output-folder-clear
But please don't merge it now. @tiramisuq still needs some change in the swagger pipeline to make the automation work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure. Ping me when this PR is ready to merge.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.json
automatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json
.