Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swagger-to-cli-automation-config #1537

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Conversation

qiaozha
Copy link
Member

@qiaozha qiaozha commented Apr 14, 2020


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/Azure/azure-cli-extensions.git@swagger-to-cli-automation#subdirectory=src/$EXT&egg=$EXT"

@yonzhan yonzhan requested a review from jsntcy April 14, 2020 11:52
@yonzhan yonzhan requested a review from haroldrandom April 14, 2020 11:52
@yonzhan yonzhan added this to the S168 milestone Apr 14, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 14, 2020

add to S168

@yonzhan yonzhan requested a review from mmyyrroonn April 14, 2020 11:53
"version": "3.0.6198",
"sdkrel:output-folder":".",
"clear-output-folder":"false"
"version": "3.0.6271",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it on purpose to remove output-folder?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. the latest @autorest/az package 1.3.2 use --azure-cli-extension-folder instead of --output-folder to specify the output location. @autorest/az will add the src/extension-name.
it also allows the --clear-output-folder except manual folder.
Futher info can found here.
https://github.com/Azure/autorest.az/blob/master/doc/faq.md#what-would-the-clear-output-folder-clear
But please don't merge it now. @tiramisuq still needs some change in the swagger pipeline to make the automation work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. Ping me when this PR is ready to merge.

@mmyyrroonn mmyyrroonn merged commit d904703 into master Apr 16, 2020
@wangzelin007 wangzelin007 deleted the swagger-to-cli-automation branch November 18, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants