Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline cli extension automation onboarding #1397

Merged
merged 3 commits into from
Mar 18, 2020

Conversation

xiaoxuqi-ms
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/tiramisuq/azure-cli-extensions.git@pipeline_cli_package#subdirectory=src/$EXT&egg=$EXT"

@haroldrandom
Copy link
Contributor

Context?

@haroldrandom
Copy link
Contributor

better to list the background and usage in the file to inform people who don't know the context.
Besides, can you put into a folder like scripts/ci/swagger?

@xiaoxuqi-ms
Copy link
Member Author

Cli extension codegen intends to use pipeline to generate codes automatically and this file is used as configuration used in pipeline. For current work flow, it should reside in the direct folder under the repo.

@haroldrandom haroldrandom requested a review from jsntcy March 17, 2020 06:35
@haroldrandom
Copy link
Contributor

@jsntcy Please take a look

@yonzhan yonzhan added this to the S167 milestone Mar 17, 2020
@qiaozha qiaozha merged commit 0c4e8d5 into Azure:master Mar 18, 2020
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
* pipeline cli automation

* update az version

Co-authored-by: Xiaoxu Qi <xiaoxuqi@microsoft.com>
Co-authored-by: Yu Chen <ychenu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants