-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breadth Coverage] Stream Analytics #1386
Conversation
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
|
Can you share the speclet here? |
Here is the speclet: https://microsoft.sharepoint.com/:w:/r/teams/AzureManagementExperience/_layouts/15/guestaccess.aspx?e=4dwWBD&share=EdkCjo-EyDxFm8dpGrzOnCwBowMITT2zU98URXfkRN2SPg |
Add a |
src/stream-analytics/azext_stream_analytics/vendored_sdks/streamanalytics/models/_models.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a init.py file in vendored_sdks so it will be packaged in wheel like this.
Nice finding. Added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. some minor comments.
* [Breadth Coverage] Stream Analytics * update CODEOWNERS * update stream analytics README file * fix review problem * add long running operation support & fix style error * fix linter error * add more examples for input/output/function create * align value name with parameter name * fix review problems * fix wait command problem Co-authored-by: Xiaojian Xu <xiaojxu@microsoft.com>
Onboard Stream Analytics
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.json
automatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json
.