Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breadth Coverage] Stream Analytics #1386

Merged
merged 12 commits into from
Mar 17, 2020
Merged

[Breadth Coverage] Stream Analytics #1386

merged 12 commits into from
Mar 17, 2020

Conversation

arrownj
Copy link
Contributor

@arrownj arrownj commented Mar 13, 2020

Onboard Stream Analytics


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/arrownj/azure-cli-extensions.git@stream_analytics#subdirectory=src/$EXT&egg=$EXT"

@qwordy
Copy link
Member

qwordy commented Mar 13, 2020

Can you share the speclet here?

@arrownj
Copy link
Contributor Author

arrownj commented Mar 13, 2020

@fengzhou-msft
Copy link
Member

Add a __init__.py file in vendored_sdks so it will be packaged in wheel like this.

Copy link
Contributor Author

@arrownj arrownj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a init.py file in vendored_sdks so it will be packaged in wheel like this.

Nice finding. Added.

Copy link
Member

@yungezz yungezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. some minor comments.

src/stream-analytics/README.md Outdated Show resolved Hide resolved
src/stream-analytics/README.md Outdated Show resolved Hide resolved
src/stream-analytics/azext_stream_analytics/_params.py Outdated Show resolved Hide resolved
@arrownj arrownj merged commit a2350da into Azure:master Mar 17, 2020
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
* [Breadth Coverage] Stream Analytics

* update CODEOWNERS

* update stream analytics README file

* fix review problem

* add long running operation support & fix style error

* fix linter error

* add more examples for input/output/function create

* align value name with parameter name

* fix review problems

* fix wait command problem

Co-authored-by: Xiaojian Xu <xiaojxu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants