-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] add prechek logic in job LintModifiedExtension #1334
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
|
haroldrandom
changed the title
[CI] Add Release pipeline Precheks in job Linter
[CI] add precheks in job LintModifiedExtension
Mar 2, 2020
haroldrandom
requested review from
mmyyrroonn,
qianwens,
jsntcy,
Juliehzl and
fengzhou-msft
March 2, 2020 08:49
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
haroldrandom
requested review from
mmyyrroonn,
Juliehzl,
qianwens,
yonzhan,
jsntcy,
yungezz and
fengzhou-msft
March 5, 2020 10:55
add to S166 |
haroldrandom
changed the title
[CI] add precheks in job LintModifiedExtension
[CI] add prechek logic in job LintModifiedExtension
Mar 6, 2020
mmyyrroonn
reviewed
Mar 6, 2020
mmyyrroonn
reviewed
Mar 6, 2020
mmyyrroonn
approved these changes
Mar 11, 2020
Co-Authored-By: Feng Zhou <55177366+fengzhou-msft@users.noreply.github.com>
fengzhou-msft
approved these changes
Mar 12, 2020
ManuInNZ
pushed a commit
to ManuInNZ/azure-cli-extensions
that referenced
this pull request
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1028, after approved, I will rename the job to LintModifiedExtension
Scenario 1: User modify other files, instead of source code and src/index.json. CI should pass (Please see the build's output of this PR).
Scenario 2: User modify src/index.json only and metadata item refer to extension not
inside our repo (#1333), CI will pass and job linter will skip and do nothing.
Scenario 3: User modify both src/index.json and extension source code (#1336), CI shall fail with a warning message.
Scenario 4: User modify src/index.json only and metadata item refer to extension inside our repo (#1337). CI will pass and job linter will skip and do nothing.
Scenario 5: User modify extension source code only (#1338), and CI job "CLI Linter on Modified Extensions (New)" should build and linter on modified extensions.
Scenario 6: User delete some files of source code. (#1357),
and CI job "CLI Linter on Modified Extensions (New)" should skip to build with output
the extension and pass. But other CI job will fail as missing some necessary files
Scenario 7: User delete the whole extension source (#1358), and CI job "CLI Linter on Modified Extensions (New)" should skip to do nothing and pass.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions: