codegen onboard datafactory #1321
Conversation
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
src/datafactory/README.md
Outdated
| ========================================== | ||
|
|
||
| This package is for the 'datafactory' extension. | ||
| i.e. 'az datafactory' |
There was a problem hiding this comment.
Please add more description, like https://github.com/Azure/azure-cli-extensions/blob/master/src/storage-preview/README.md
There was a problem hiding this comment.
This has not been fixed yet, the outdated status is outdated just because I changed the eof mark.
|
datafactory |
| examples: | ||
| - name: Factories_Get | ||
| text: |- | ||
| az datafactory factory show --name "exampleFactoryName" --resource-group "exampleResourceGroup" |
There was a problem hiding this comment.
Recommend to use MyFactoryName and MyResourceGroup to follow the example value pattern.
There was a problem hiding this comment.
This has not been fixed yet, the outdated status is outdated just because I changed the eof mark.
There was a problem hiding this comment.
This should've been fixed, please check again. thx
|
@fengzhou-msft @Juliehzl All the issues should've been resolved, please go ahead and review it. thx. |
| KEY_VNET_NIC = 'nic' | ||
|
|
||
|
|
||
| class VirtualNetworkPreparer(NoTrafficRecordingPreparer, SingleValueReplacer): |
There was a problem hiding this comment.
remove this file if not used.
There was a problem hiding this comment.
@changlong-liu Will the current preparer generation logic generate all type of Preparer no matter it's used or not?
| return client.update(resource_group_name=resource_group_name, | ||
| factory_name=factory_name, | ||
| tags=tags, | ||
| identity=json.loads("{\"type\": \"SystemAssigned\"}")) |
There was a problem hiding this comment.
Would this also work?
| identity=json.loads("{\"type\": \"SystemAssigned\"}")) | |
| identity={"type": "SystemAssigned"}) |
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions: