-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{omsagent} role assignment changes for msi (#1) #1258
Conversation
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
|
add to S165. |
* {omsagent} role assignment changes for msi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello. Like we talked offline, could you change the help message in extension too? Better to have same code with the main azure cli
I have added the changes in the help too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with this one. Azure/azure-cli#12100 (review) LGTM. Could you please update the index.json in the same PR?
Role assignment changes to assign role for msi if it is created for omsagent addon