Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{omsagent} role assignment changes for msi (#1) #1258

Merged
merged 20 commits into from
Feb 24, 2020

Conversation

rashmichandrashekar
Copy link
Contributor

Role assignment changes to assign role for msi if it is created for omsagent addon

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/rashmichandrashekar/azure-cli-extensions.git@master#subdirectory=src/$EXT&egg=$EXT"

@yonzhan yonzhan requested review from qwordy, jiasli, arrownj, jiacfan and mmyyrroonn and removed request for jiacfan February 8, 2020 01:33
@yonzhan yonzhan added this to the S165 milestone Feb 8, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Feb 8, 2020

add to S165.

Copy link
Contributor

@mmyyrroonn mmyyrroonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello. Like we talked offline, could you change the help message in extension too? Better to have same code with the main azure cli

@rashmichandrashekar
Copy link
Contributor Author

Hello. Like we talked offline, could you change the help message in extension too? Better to have same code with the main azure cli

I have added the changes in the help too

Copy link
Contributor

@mmyyrroonn mmyyrroonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with this one. Azure/azure-cli#12100 (review) LGTM. Could you please update the index.json in the same PR?

@mmyyrroonn mmyyrroonn merged commit 617e5aa into Azure:master Feb 24, 2020
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants