Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websites: Adding metadata to support the isPreview feature #108

Merged
merged 5 commits into from
Apr 18, 2018

Conversation

panchagnula
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run ./scripts/ci/test_static.sh locally? (pip install pylint flake8 required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/panchagnula/azure-cli-extensions.git@sisirap-updatingNewToUp#subdirectory=src/$EXT&egg=$EXT"

@derekbekoe
Copy link
Member

@panchagnula Change the description.
Also, you don't need the last comma after DEPENDENCIES

@derekbekoe
Copy link
Member

Also, it's not azext_aem

@derekbekoe
Copy link
Member

@panchagnula Please take a look at this PR otherwise I'll close soon. Thanks.

@panchagnula
Copy link
Contributor Author

@derekbekoe i will get to this soon - sorry was out of office & now working on //BUILD work items.

@panchagnula panchagnula changed the title Fixing setup.py Websites: Adding metadata to support the isPreview feature Apr 18, 2018
@panchagnula
Copy link
Contributor Author

@derekbekoe can you help me figure out the Travis CI build error?

src/index.json Outdated
"metadata": {
"azext.minCliCoreVersion": "2.0.24",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add "azext.isPreview": true here also.

@panchagnula panchagnula merged commit 5b85700 into Azure:master Apr 18, 2018
@panchagnula panchagnula deleted the sisirap-updatingNewToUp branch April 18, 2018 23:35
StrawnSC added a commit to StrawnSC/azure-cli-extensions that referenced this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants