Add extension ip-group for feature requested in 10726 #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
mmyyrroonn
suggested changes
Oct 29, 2019
haroldrandom
force-pushed
the
issue_10726
branch
from
60f3671 to
9cc0d55
Compare
mmyyrroonn
reviewed
Oct 30, 2019
| with cmd.update_context(instance) as c: | ||
| c.set_param('tags', tags) | ||
|
|
||
| if ip_addresses is not None: | ||
| c.set_param('ip_addresses', ip_addresses) |
There was a problem hiding this comment.
c.set_param will check if ip_addresses is not None. We don't need if ip_addresses is not None
mmyyrroonn
approved these changes
Oct 30, 2019
ManuInNZ
pushed a commit
to ManuInNZ/azure-cli-extensions
that referenced
this pull request
Apr 11, 2020
* Add ip-group extension * Remove TODO * Remove buggy dependency and Add --ip-addresses option to update * Fix PEP8 error * Remove redundant None-checking of --ip-addresses when updating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extension ip-group for azure-cli feature requested in 10726
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions: