Skip to content

Commit

Permalink
[db-up] Set the max CLI core version as 2.0.66 (#738)
Browse files Browse the repository at this point in the history
* [db-up] Set the max CLI core version as 2.0.66

* [db-up] Publish 0.1.12

* [db-up] Remove config_parser
  • Loading branch information
limingu authored and yugangw-msft committed Jun 6, 2019
1 parent 3110cfb commit 27221db
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 20 deletions.
5 changes: 1 addition & 4 deletions src/db-up/azext_db_up/_validators.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from msrest.exceptions import ValidationError
from azext_db_up._client_factory import resource_client_factory
from azext_db_up.random_name.generate import generate_username
from azext_db_up.util import create_random_resource_name, get_config_value, set_config_value, remove_section
from azext_db_up.util import create_random_resource_name, get_config_value, set_config_value

logger = get_logger(__name__)

Expand Down Expand Up @@ -74,9 +74,6 @@ def _process_db_down_namespace(namespace, db_type=None):
_set_value(db_type, namespace, 'resource_group_name', 'group', cache=False)
_set_value(db_type, namespace, 'server_name', 'server', cache=False)

# delete information in config
remove_section(db_type)

# put resource group info back in config if user does not want to delete it
if not namespace.delete_group:
_set_value(db_type, namespace, 'resource_group_name', 'group')
Expand Down
1 change: 1 addition & 0 deletions src/db-up/azext_db_up/azext_metadata.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"azext.maxCliCoreVersion": "2.0.66",
"azext.minCliCoreVersion": "2.0.46",
"azext.isPreview": true
}
11 changes: 0 additions & 11 deletions src/db-up/azext_db_up/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,17 +39,6 @@ def set_config_value(db_type, option, value):
DB_CONFIG.set_value(config_section, option, value)


def remove_config_value(db_type, option):
config_section = CONFIG_MAP[db_type]
DB_CONFIG.config_parser.remove_option(config_section, option)


def remove_section(db_type):
config_section = CONFIG_MAP[db_type]
DB_CONFIG.config_parser.remove_section(config_section)
DB_CONFIG.set(DB_CONFIG.config_parser)


def update_kwargs(kwargs, key, value):
if value is not None:
kwargs[key] = value
Expand Down
2 changes: 1 addition & 1 deletion src/db-up/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from codecs import open
from setuptools import setup, find_packages

VERSION = "0.1.11"
VERSION = "0.1.12"

CLASSIFIERS = [
'Development Status :: 4 - Beta',
Expand Down
9 changes: 5 additions & 4 deletions src/index.json
Original file line number Diff line number Diff line change
Expand Up @@ -739,10 +739,11 @@
],
"db-up": [
{
"downloadUrl": "https://azurecliprod.blob.core.windows.net/cli-extensions/db_up-0.1.11-py2.py3-none-any.whl",
"filename": "db_up-0.1.11-py2.py3-none-any.whl",
"downloadUrl": "https://azurecliprod.blob.core.windows.net/cli-extensions/db_up-0.1.12-py2.py3-none-any.whl",
"filename": "db_up-0.1.12-py2.py3-none-any.whl",
"metadata": {
"azext.isPreview": true,
"azext.maxCliCoreVersion": "2.0.66",
"azext.minCliCoreVersion": "2.0.46",
"classifiers": [
"Development Status :: 4 - Beta",
Expand Down Expand Up @@ -789,9 +790,9 @@
}
],
"summary": "Additional commands to simplify Azure Database workflows.",
"version": "0.1.11"
"version": "0.1.12"
},
"sha256Digest": "a7363f90c941faf83c026a02c5f5dc9169438a260b6dfcf42258bb6b5f193387"
"sha256Digest": "dee084df22beeaa6b3f583ca4af154a60f6364368aa900d06fd576c1d5ee0df3"
}
],
"dev-spaces": [
Expand Down

0 comments on commit 27221db

Please sign in to comment.