Repository navigation
Pin transitive js-yaml to 3.15.2 to remediate GHSA-2883-xcg3-v3hh - #1011
Merged
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: hemarina <104857065+hemarina@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix js-yaml CPU usage vulnerability in maxTotalMergeKeys
Pin transitive Sep 10, 2026
js-yaml to 3.15.2 to remediate GHSA-2883-xcg3-v3hh
Marina He (hemarina)
marked this pull request as ready for review
September 10, 2026 18:45
Marina He (hemarina)
enabled auto-merge (squash)
September 10, 2026 18:45
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The lockfile contains substantial unrelated churn beyond the intended js-yaml remediation, which should be minimized or explicitly justified.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Pins a vulnerable transitive js-yaml@3.15.1 resolution to the lowest patched version (3.15.2) using npm overrides, aiming to remediate GHSA-2883-xcg3-v3hh with minimal impact to the dependency graph.
Changes:
- Added an npm
overridesentry scoping@istanbuljs/load-nyc-configto usejs-yaml@3.15.2. - Regenerated
website/package-lock.jsonso the@istanbuljs/load-nyc-configsubtree no longer resolvesjs-yaml@3.15.1.
File summaries
| File | Description |
|---|---|
| website/package.json | Adds a targeted npm override to force @istanbuljs/load-nyc-config → js-yaml@3.15.2. |
| website/package-lock.json | Updates the locked transitive js-yaml version (and includes additional lockfile normalization churn). |
Review details
Files not reviewed (1)
- website/package-lock.json: Generated file
- Files reviewed: 1/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: hemarina <104857065+hemarina@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused override and lockfile update consistently remove the vulnerable resolution.
Review details
Files not reviewed (1)
- website/package-lock.json: Generated file
- Files reviewed: 1/2 changed files
- Comments generated: 0 new
- Review effort level: Balanced
Marina He (hemarina)
approved these changes
Sep 10, 2026
Victor Vazquez (vhvb1989)
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
js-yaml3.15.1is vulnerable to CPU exhaustion via repeated merge-key processing of empty mappings. This PR updates the vulnerable transitive resolution to the lowest patched version (3.15.2) with minimal dependency graph impact.Change scope
website/package.jsonto force@istanbuljs/load-nyc-configto resolvejs-yamlto3.15.2.website/package-lock.jsonso the@istanbuljs/load-nyc-configsubtree no longer resolvesjs-yaml@3.15.1.Implementation
{ "overrides": { "@istanbuljs/load-nyc-config": { "js-yaml": "3.15.2" } } }Reachability Assessment
js-yamlv3/v4 loaders.@istanbuljs/load-nyc-config), not the site runtime path.website/scripts/extract-template-metadata.js) uses top-leveljs-yamlwithFAILSAFE_SCHEMAandmaxAliasCount, not the vulnerable3.15.1node.Original prompt
This section details the Dependabot vulnerability alert you should resolve
<alert_title>js-yaml: maxTotalMergeKeys does not limit CPU use for empty merge sources</alert_title>
<alert_description>## Summary
maxTotalMergeKeysdoes not count empty mappings. An attacker can repeatedly merge a large sequence of them and consume significant CPU without reaching the configured limit.Example
For every target, the loader iterates all
Nelements ofarr. This results inO(N * K)work whiletotalMergeKeysremains unchanged.PoC
Observed results:
Impact
An attacker can submit a relatively small YAML document that causes prolonged CPU consumption despite the default
maxTotalMergeKeyslimit.Fix
Count each merge-source mapping as one budget unit, in addition to counting its keys.
Difference with v5
In v3 & v4, merge is enabled by default. So, the severity score is higher.</alert_description>
high
https://github.com/nodeca/js-yaml/security/advisories/GHSA-2883-xcg3-v3hh https://nvd.nist.gov/vuln/detail/CVE-2026-84375 https://github.com/nodeca/js-yaml/pull/797 https://github.com/nodeca/js-yaml/commit/3485bc06ff8a0251505f44a00414d90df2466639 https://github.com/nodeca/js-yaml/commit/6a8e05f9a485188ed730ac81e81ae221352ef480 https://github.com/nodeca/js-yaml/commit/d90b6612a5a84385bdcb556c44578eac76dc0f6b https://github.com/nodeca/js-yaml/releases/tag/3.15.2 https://github.com/nodeca/js-yaml/releases/tag/4.3.2 https://github.com/advisories/GHSA-2883-xcg3-v3hhGHSA-2883-xcg3-v3hh, CVE-2026-84375
js-yaml
npm
<vulnerable_versions>3.15.1</vulnerable_versions>
<patched_version>3.15.2</patched_version>
<manifest_path>website/package-lock.json</manifest_path>
<task_instructions>Resolve this alert by updating the affected package to a non-vulnerable version. Prefer the lowest non-vulnerable version (see the patched_version field above) over the latest to minimize breaking changes. Include a Reachability Assessment section in the PR description. Review the alert_description field to understand which APIs, features, or configurations are affected, then search the codebase for usage of those specific items. If the vulnerable code path is reachable, explain how (which files, APIs, or call sites use the affected functionality) and note that the codebase is actively exposed to this vulnerability. If the vulnerable code path is not reachable, explain why (e.g. the affected API is never called, the vulnerable configuration is not used) and note that the update is primarily to satisfy vulnerability scanners rather than to address an active risk. If the advisory is too vague to determine reachability (e.g. 'improper input validation' with no specific API named), state that reachability could not be determined and explain why. Include a confidence level in the reachability assessment (e.g. high confidence if the advisory names a specific API and you confirmed it is or is not called, low confidence if the usage is indirect and hard to trace). If no patched version is available, check the alert_description field for a Workarounds section — the advisory may describe configuration changes or usage patterns that mitigate the vulnerability without a version update. If a workaround is available, apply it and leave a code comment referencing the advisory identifier explaining it is a temporary mitigation. If neither a patch nor a workaround is available, explain in the PR description why the alert cannot be resolved automatically so a human reviewer can take over. Inspect the repository to determine which package manager is used (e.g. lock files, config files, build scripts) and use that tooling to perform the update — do not edit lock files directly. If the version constraint in the manifest (e.g. package.json, Gemfile, pyproject.toml) caps the version below the fix, update the constraint first. For transitive dependencies, determine whether it is simpler to update the direct dependency that pulls in the vulnerable package or to update the transitive dependency directly, and choose the least disruptive approach. If upgrading to fix the vulnerability forces a major version bump or known ...