Add download streaming support

.travis.yml

@@ -24,6 +24,7 @@ install:
   - export LD_LIBRARY_PATH=$HOME/.local/lib/:$LD_LIBRARY_PATH
   # Install npm
   - curl -sSL https://raw.githubusercontent.com/aspnet/Home/dev/dnvminstall.sh | sh && source ~/.dnx/dnvm/dnvm.sh && dnvm upgrade
+  - rm -rf ~/.nvm && git clone https://github.com/creationix/nvm.git ~/.nvm && (cd ~/.nvm && git checkout `git describe --abbrev=0 --tags`) && source ~/.nvm/nvm.sh && nvm install 4
   - npm install -g npm@'>=1.4.3'
   - npm install
   # Install ruby dependencies
@@ -49,4 +50,4 @@ after_script:
   - cat TestResults/*.log
 notifications:
   slack:
-    secure: d0PFVLcyqcMxNtmZ8JaEpIBzXbUbZCgKs8QtBB5qEIXDnxflSR3AhczlILNhTBKtMEBlwVzsz65yP09XcmvB6xpAfJbHqSRzk2frKa5viPcAD8Wr/NYamt9/UiTCsnql8MqzjVy0tLdMscXKRmsUey4YF570zl0b7gAbq7XTqxM=
+    secure: d0PFVLcyqcMxNtmZ8JaEpIBzXbUbZCgKs8QtBB5qEIXDnxflSR3AhczlILNhTBKtMEBlwVzsz65yP09XcmvB6xpAfJbHqSRzk2frKa5viPcAD8Wr/NYamt9/UiTCsnql8MqzjVy0tLdMscXKRmsUey4YF570zl0b7gAbq7XTqxM=

AutoRest/Generators/Java/Azure.Java/Templates/AzureMethodGroupRetrofitTemplate.cshtml

@@ -31,6 +31,10 @@ else
 {
 @:    @@@(method.HttpMethod.ToString().ToUpper())("@(method.Url.TrimStart('/'))")
 }
+if (method.ReturnType.Body.IsPrimaryType(KnownPrimaryType.Stream))
+{
+@:    @@Streaming
+}
 @:    Call<@method.CallType> @(method.Name)(@method.MethodParameterApiDeclaration);
 @EmptyLine
 }

AutoRest/Generators/Java/Azure.Java/Templates/AzureServiceClientRetrofitTemplate.cshtml

@@ -31,6 +31,10 @@ else
 {
 @:    @@@(method.HttpMethod.ToString().ToUpper())("@(method.Url.TrimStart('/'))")
 }
+if (method.ReturnType.Body.IsPrimaryType(KnownPrimaryType.Stream))
+{
+@:    @@Streaming
+}
 @:    Call<@method.CallType> @(method.Name)(@method.MethodParameterApiDeclaration);
 @EmptyLine
 }

AutoRest/Generators/Java/Java.Tests/src/main/java/fixtures/bodyfile/FilesOperationsImpl.java

@@ -23,6 +23,7 @@
 import retrofit2.Call;
 import retrofit2.http.GET;
 import retrofit2.http.Headers;
+import retrofit2.http.Streaming;
 import retrofit2.Response;
 import retrofit2.Retrofit;
 
@@ -54,14 +55,17 @@ public FilesOperationsImpl(Retrofit retrofit, AutoRestSwaggerBATFileService clie
     interface FilesService {
         @Headers("Content-Type: application/json; charset=utf-8")
         @GET("files/stream/nonempty")
+        @Streaming
         Call<ResponseBody> getFile();
 
         @Headers("Content-Type: application/json; charset=utf-8")
         @GET("files/stream/verylarge")
+        @Streaming
         Call<ResponseBody> getFileLarge();
 
         @Headers("Content-Type: application/json; charset=utf-8")
         @GET("files/stream/empty")
+        @Streaming
         Call<ResponseBody> getEmptyFile();
 
     }

AutoRest/Generators/Java/Java.Tests/src/main/java/fixtures/bodyformdata/FormdataOperationsImpl.java

@@ -30,6 +30,7 @@
 import retrofit2.http.Part;
 import retrofit2.http.POST;
 import retrofit2.http.PUT;
+import retrofit2.http.Streaming;
 import retrofit2.Response;
 import retrofit2.Retrofit;
 
@@ -61,10 +62,12 @@ public FormdataOperationsImpl(Retrofit retrofit, AutoRestSwaggerBATFormDataServi
     interface FormdataService {
         @Multipart
         @POST("formdata/stream/uploadfile")
+        @Streaming
         Call<ResponseBody> uploadFile(@Part("fileContent") RequestBody fileContent, @Part("fileName") String fileName);
 
         @Headers("Content-Type: application/octet-stream")
         @PUT("formdata/stream/uploadfile")
+        @Streaming
         Call<ResponseBody> uploadFileViaBody(@Body RequestBody fileContent);
 
     }

AutoRest/Generators/Java/Java.Tests/src/test/java/fixtures/bodyfile/FilesTests.java

@@ -1,19 +1,23 @@
 package fixtures.bodyfile;
 
-import org.junit.Assert;
 import org.apache.commons.io.IOUtils;
+import org.junit.Assert;
 import org.junit.BeforeClass;
 import org.junit.Test;
-import org.junit.Ignore;
 
 import java.io.InputStream;
+import java.util.concurrent.TimeUnit;
+
+import okhttp3.OkHttpClient;
+import retrofit2.Retrofit;
 
 public class FilesTests {
     private static AutoRestSwaggerBATFileService client;
 
     @BeforeClass
     public static void setup() {
-        client = new AutoRestSwaggerBATFileServiceImpl("http://localhost.:3000");
+        OkHttpClient.Builder builder = new OkHttpClient.Builder().readTimeout(1, TimeUnit.MINUTES);
+        client = new AutoRestSwaggerBATFileServiceImpl("http://localhost.:3000", builder, new Retrofit.Builder());
     }
 
     @Test
@@ -27,11 +31,10 @@ public void getFile() throws Exception {
         }
     }
 
-    @Ignore("This fails -- needs to be fixed")
+    @Test
     public void getLargeFile() throws Exception {
-        ClassLoader classLoader = getClass().getClassLoader();
         try (InputStream result = client.getFilesOperations().getFileLarge().getBody()) {
-            long streamSize = 3000 * 1024 * 1024;
+            long streamSize = 3000L * 1024L * 1024L;
             long skipped = result.skip(streamSize);
             Assert.assertEquals(streamSize, skipped);
         }

AutoRest/Generators/Java/Java.Tests/src/test/java/fixtures/report/CoverageReporter.java

@@ -29,8 +29,6 @@ public static void main(String[] args) throws Exception {
         report.put("HttpRedirect301Put", 1);
         report.put("HttpRedirect302Patch", 1);
 
-        report.put("FileStreamVeryLarge", 1);
-
         int total = report.size();
         int hit = 0;
         List<String> missing = new ArrayList<>();

AutoRest/Generators/Java/Java/TemplateModels/MethodTemplateModel.cs

@@ -799,6 +799,10 @@ public virtual List<string> ImplImports
                     .ForEach(p => imports.AddRange(p.ImportFrom()));
                 // return type
                 imports.AddRange(this.ReturnType.Body.ImportFrom(ServiceClient.Namespace, Namer));
+                if (ReturnType.Body.IsPrimaryType(KnownPrimaryType.Stream))
+                {
+                    imports.Add("retrofit2.http.Streaming");
+                }
                 // response type (can be different from return type)
                 this.Responses.ForEach(r => imports.AddRange(r.Value.Body.ImportFrom(ServiceClient.Namespace, Namer)));
                 // Header type

AutoRest/Generators/Java/Java/Templates/MethodGroupRetrofitTemplate.cshtml

@@ -27,6 +27,10 @@ else
 {
 @:    @@@(method.HttpMethod.ToString().ToUpper())("@(method.Url.TrimStart('/'))")
 }
+if (method.ReturnType.Body.IsPrimaryType(KnownPrimaryType.Stream))
+{
+@:    @@Streaming
+}
 @:    Call<@method.CallType> @(method.Name)(@method.MethodParameterApiDeclaration);
 @EmptyLine
 }

AutoRest/Generators/Java/Java/Templates/ServiceClientRetrofitTemplate.cshtml

@@ -27,6 +27,10 @@ else
 {
 @:    @@@(method.HttpMethod.ToString().ToUpper())("@(method.Url.TrimStart('/'))")
 }
+if (method.ReturnType.Body.IsPrimaryType(KnownPrimaryType.Stream))
+{
+@:    @@Streaming
+}
 @:    Call<@method.CallType> @(method.Name)(@method.MethodParameterApiDeclaration);
 @EmptyLine
 }

ClientRuntimes/Java/client-runtime/src/main/java/com/microsoft/rest/ServiceResponseBuilder.java

@@ -272,7 +272,6 @@ protected Object buildBody(int statusCode, ResponseBody responseBody) throws IOE
         // Return raw response if InputStream is the target type
         else if (type == InputStream.class) {
             InputStream stream = responseBody.byteStream();
-            responseBody.close();
             return stream;
         }
         // Deserialize