LLC, fix example generation with x-ms-client-name #1321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weidongxu-microsoft
changed the title
Comment on lines
+258
to
+263
| Map<String, ProxyMethodParameter> proxyMethodParameterByClientParameterName = proxyMethod.getParameters().stream() | ||
| .collect(Collectors.toMap(p -> CodeNamer.getEscapedReservedClientMethodParameterName(p.getName()), Function.identity())); | ||
| List<ProxyMethodParameter> proxyMethodParameters = new ArrayList<>(); | ||
| for (ClientMethodParameter clientMethodParameter : clientMethodParameters) { | ||
| ProxyMethodParameter proxyMethodParameter = proxyMethodParameterByClientParameterName.get(clientMethodParameter.getName()); | ||
| proxyMethodParameters.add(proxyMethodParameter); |
Member
Author
There was a problem hiding this comment.
Maybe we should put requestParameterLocation to client method parameter, instead of making the mapping.
javagen/src/main/java/com/azure/autorest/template/ProtocolSampleTemplate.java
Outdated
Show resolved
Hide resolved
haolingdong-msft
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1313
case of the parameter not in method signature already fixed in #1311
this PR fix the case of the parameter in method signature (usually path parameter and body parameter).