-
Notifications
You must be signed in to change notification settings - Fork 82
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
client, fix bug on POM dependency parse (#2958)
- Loading branch information
1 parent
e283800
commit 032c478
Showing
12 changed files
with
193 additions
and
11 deletions.
There are no files selected for viewing
Submodule core
updated
27 files
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
...va/com/microsoft/typespec/http/client/generator/core/model/projectmodel/ProjectTests.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
// Copyright (c) Microsoft Corporation. All rights reserved. | ||
// Licensed under the MIT License. | ||
|
||
package com.microsoft.typespec.http.client.generator.core.model.projectmodel; | ||
|
||
import org.junit.jupiter.api.Assertions; | ||
import org.junit.jupiter.api.Test; | ||
|
||
import java.net.URISyntaxException; | ||
import java.nio.file.Path; | ||
import java.nio.file.Paths; | ||
import java.util.List; | ||
|
||
public class ProjectTests { | ||
|
||
@Test | ||
public void testParsePom() throws URISyntaxException { | ||
Path pomPath = Paths.get(ProjectTests.class.getClassLoader().getResource("test-pom.xml").toURI()); | ||
|
||
List<String> dependencyIdentifiers = Project.findPomDependencies(pomPath); | ||
|
||
Assertions.assertTrue(dependencyIdentifiers.contains("com.azure.resourcemanager:azure-resourcemanager-resources:2.42.0:test")); | ||
} | ||
} |
45 changes: 45 additions & 0 deletions
45
...t/java/com/microsoft/typespec/http/client/generator/mgmt/mapper/FluentPomMapperTests.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
// Copyright (c) Microsoft Corporation. All rights reserved. | ||
// Licensed under the MIT License. | ||
|
||
package com.microsoft.typespec.http.client.generator.mgmt.mapper; | ||
|
||
import com.microsoft.typespec.http.client.generator.core.model.clientmodel.Pom; | ||
import com.microsoft.typespec.http.client.generator.mgmt.FluentGen; | ||
import com.microsoft.typespec.http.client.generator.mgmt.FluentGenAccessor; | ||
import com.microsoft.typespec.http.client.generator.mgmt.TestUtils; | ||
import com.microsoft.typespec.http.client.generator.mgmt.model.projectmodel.FluentProject; | ||
import org.junit.jupiter.api.Assertions; | ||
import org.junit.jupiter.api.BeforeAll; | ||
import org.junit.jupiter.api.Test; | ||
import org.mockito.Mockito; | ||
|
||
import java.util.List; | ||
|
||
public class FluentPomMapperTests { | ||
|
||
private static FluentGenAccessor fluentgenAccessor; | ||
|
||
@BeforeAll | ||
public static void ensurePlugin() { | ||
FluentGen fluentgen = new TestUtils.MockFluentGen(); | ||
fluentgenAccessor = new FluentGenAccessor(fluentgen); | ||
} | ||
|
||
@Test | ||
public void testMergeDependencies() { | ||
String additionalDependencyIdentifier = "com.azure.resourcemanager:azure-resourcemanager-resources:2.42.0:test"; | ||
|
||
FluentProject fluentProject = Mockito.mock(FluentProject.class); | ||
Mockito.when(fluentProject.getGroupId()).thenReturn("com.azure.resourcemanager"); | ||
Mockito.when(fluentProject.getArtifactId()).thenReturn("azure-resourcemanager-mock"); | ||
Mockito.when(fluentProject.getVersion()).thenReturn("1.0.0-beta.1"); | ||
Mockito.when(fluentProject.getServiceName()).thenReturn("MockManagement"); | ||
Mockito.when(fluentProject.getServiceDescription()).thenReturn("MockManagement"); | ||
Mockito.when(fluentProject.getServiceDescriptionForPom()).thenReturn("MockManagement"); | ||
Mockito.when(fluentProject.getPomDependencyIdentifiers()).thenReturn(List.of(additionalDependencyIdentifier)); | ||
|
||
Pom pom = new FluentPomMapper().map(fluentProject); | ||
|
||
Assertions.assertTrue(pom.getDependencyIdentifiers().stream().anyMatch(p -> p.equals(additionalDependencyIdentifier))); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,105 @@ | ||
<!-- | ||
~ Copyright (c) Microsoft Corporation. All rights reserved. | ||
~ Licensed under the MIT License. | ||
~ Code generated by Microsoft (R) AutoRest Code Generator. | ||
--> | ||
<project xmlns="http://maven.apache.org/POM/4.0.0" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"> | ||
<modelVersion>4.0.0</modelVersion> | ||
<parent> | ||
<groupId>com.azure</groupId> | ||
<artifactId>azure-client-sdk-parent</artifactId> | ||
<version>1.7.0</version> <!-- {x-version-update;com.azure:azure-client-sdk-parent;current} --> | ||
<relativePath>../../parents/azure-client-sdk-parent</relativePath> | ||
</parent> | ||
|
||
<groupId>com.azure.resourcemanager</groupId> | ||
<artifactId>azure-resourcemanager-databricks</artifactId> | ||
<version>1.0.0-beta.5</version> <!-- {x-version-update;com.azure.resourcemanager:azure-resourcemanager-databricks;current} --> | ||
<packaging>jar</packaging> | ||
|
||
<name>Microsoft Azure SDK for AzureDatabricks Management</name> | ||
<description>This package contains Microsoft Azure SDK for AzureDatabricks Management SDK. For documentation on how to use this package, please see https://aka.ms/azsdk/java/mgmt. The Microsoft Azure management APIs allow end users to operate on Azure Databricks Workspace / Access Connector resources. Package tag package-2023-05-01.</description> | ||
<url>https://github.com/Azure/azure-sdk-for-java</url> | ||
|
||
<licenses> | ||
<license> | ||
<name>The MIT License (MIT)</name> | ||
<url>http://opensource.org/licenses/MIT</url> | ||
<distribution>repo</distribution> | ||
</license> | ||
</licenses> | ||
|
||
<scm> | ||
<url>https://github.com/Azure/azure-sdk-for-java</url> | ||
<connection>scm:git:git@github.com:Azure/azure-sdk-for-java.git</connection> | ||
<developerConnection>scm:git:git@github.com:Azure/azure-sdk-for-java.git</developerConnection> | ||
<tag>HEAD</tag> | ||
</scm> | ||
<developers> | ||
<developer> | ||
<id>microsoft</id> | ||
<name>Microsoft</name> | ||
</developer> | ||
</developers> | ||
<properties> | ||
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
<jacoco.min.linecoverage>0</jacoco.min.linecoverage> | ||
<jacoco.min.branchcoverage>0</jacoco.min.branchcoverage> | ||
</properties> | ||
<dependencies> | ||
<dependency> | ||
<groupId>com.azure</groupId> | ||
<artifactId>azure-core</artifactId> | ||
<version>1.52.0</version> <!-- {x-version-update;com.azure:azure-core;dependency} --> | ||
</dependency> | ||
<dependency> | ||
<groupId>com.azure</groupId> | ||
<artifactId>azure-core-management</artifactId> | ||
<version>1.15.3</version> <!-- {x-version-update;com.azure:azure-core-management;dependency} --> | ||
</dependency> | ||
<dependency> | ||
<groupId>com.azure</groupId> | ||
<artifactId>azure-core-test</artifactId> | ||
<version>1.27.0-beta.1</version> <!-- {x-version-update;com.azure:azure-core-test;dependency} --> | ||
<scope>test</scope> | ||
<exclusions> | ||
<exclusion> | ||
<groupId>com.azure</groupId> | ||
<artifactId>azure-core-http-jdk-httpclient</artifactId> | ||
</exclusion> | ||
</exclusions> | ||
</dependency> | ||
<dependency> | ||
<groupId>com.azure</groupId> | ||
<artifactId>azure-identity</artifactId> | ||
<version>1.13.3</version> <!-- {x-version-update;com.azure:azure-identity;dependency} --> | ||
<scope>test</scope> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.mockito</groupId> | ||
<artifactId>mockito-core</artifactId> | ||
<version>4.11.0</version> <!-- {x-version-update;org.mockito:mockito-core;external_dependency} --> | ||
<scope>test</scope> | ||
</dependency> | ||
<!-- bytebuddy dependencies are required for mockito 4.11.0 to work with Java 21. Mockito 4.11.0 is the last release --> | ||
<!-- of Mockito supporting Java 8 as a baseline. --> | ||
<dependency> | ||
<groupId>net.bytebuddy</groupId> | ||
<artifactId>byte-buddy</artifactId> | ||
<version>1.14.12</version> <!-- {x-version-update;testdep_net.bytebuddy:byte-buddy;external_dependency} --> | ||
<scope>test</scope> | ||
</dependency> | ||
<dependency> | ||
<groupId>net.bytebuddy</groupId> | ||
<artifactId>byte-buddy-agent</artifactId> | ||
<version>1.14.12</version> <!-- {x-version-update;testdep_net.bytebuddy:byte-buddy-agent;external_dependency} --> | ||
<scope>test</scope> | ||
</dependency> | ||
<dependency> | ||
<groupId>com.azure.resourcemanager</groupId> | ||
<artifactId>azure-resourcemanager-resources</artifactId> | ||
<version>2.42.0</version> <!-- {x-version-update;com.azure.resourcemanager:azure-resourcemanager-resources;dependency} --> | ||
<scope>test</scope> | ||
</dependency> | ||
</dependencies> | ||
</project> |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters