No, you are correct - we do always model as string. I was suggesting that we change that to avoid the pattern of exposing Uri on the convenience layer, only to transform it to string for the generated client, and then turn it back into a Uri for the pipeline.

ex.
https://github.com/Azure/azure-sdk-for-net/blob/5a307985a14a3523e765b77c86c01cd44ca8b0d8/sdk/tables/Azure.Data.Tables/src/TableClient.cs#L161
https://github.com/Azure/azure-sdk-for-net/blob/5a307985a14a3523e765b77c86c01cd44ca8b0d8/sdk/tables/Azure.Data.Tables/src/TableClient.cs#L173

 var endpointString = connString.TableStorageUri.PrimaryUri.ToString();
...
 _tableOperations = new TableRestClient(_diagnostics, pipeline, endpointString, _version);

https://github.com/Azure/azure-sdk-for-net/blob/5a307985a14a3523e765b77c86c01cd44ca8b0d8/sdk/tables/Azure.Data.Tables/src/Generated/TableRestClient.cs#L33
https://github.com/Azure/azure-sdk-for-net/blob/5a307985a14a3523e765b77c86c01cd44ca8b0d8/sdk/tables/Azure.Data.Tables/src/Generated/TableRestClient.cs#L44

public TableRestClient(ClientDiagnostics clientDiagnostics, HttpPipeline pipeline, string url, string version = "2019-02-02")
{
    ...
    this.url = url;

https://github.com/Azure/azure-sdk-for-net/blob/5a307985a14a3523e765b77c86c01cd44ca8b0d8/sdk/tables/Azure.Data.Tables/src/Generated/TableRestClient.cs#L136-L143

  internal HttpMessage CreateCreateRequest(TableProperties tableProperties, ResponseFormat? responsePreference, QueryOptions queryOptions)
{
    var message = _pipeline.CreateMessage();
    var request = message.Request;
    request.Method = RequestMethod.Post;
    var uri = new RawRequestUriBuilder();
    uri.AppendRaw(url, false);
    uri.AppendPath("/Tables", false);
    if (queryOptions?.Format != null)
    {
        uri.AppendQuery("$format", queryOptions.Format.Value.ToString(), true);
    }
    request.Uri = uri;

For HLCs it's never been much of a concern because the rest client is internal, but the LLC exposes the uri parameter.

[LLC] Host should be URI not string if possible #1136

Description

chamonsopenedon Apr 8, 2021

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

chamons
openedon Apr 8, 2021