Skip to content

Fixed editor update event propagates to widget #2737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export class ApiProductsViewModel extends React.Component {
const data = JSON.stringify(this.state);

return this.state.isRedesignEnabled
? <fui-api-products-runtime props={data} ></fui-api-products-runtime>
? <fui-api-products-runtime key={data} props={data} ></fui-api-products-runtime>
: this.state.layout === 'tiles'
? <api-products-tiles-runtime params={data}></api-products-tiles-runtime>
: this.state.layout === 'dropdown'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export class ListOfApisViewModel extends React.Component {
const data = JSON.stringify(this.state);

return this.state.isRedesignEnabled
? <fui-api-list-runtime props={data} ></fui-api-list-runtime>
? <fui-api-list-runtime key={data} props={data} ></fui-api-list-runtime>
: this.state.layout === 'tiles'
? <api-list-tiles params={data}></api-list-tiles>
: this.state.layout === 'dropdown'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export class OperationDetailsViewModel extends React.Component {
const data = JSON.stringify(this.state);

return this.state.isRedesignEnabled
? <fui-operation-details props={data} ></fui-operation-details>
? <fui-operation-details key={data} props={data} ></fui-operation-details>
: <operation-details params={data}></operation-details>;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export class ProductApisViewModel extends React.Component {
const data = JSON.stringify(this.state);

return this.state.isRedesignEnabled
? <fui-product-apis-runtime props={data} ></fui-product-apis-runtime>
? <fui-product-apis-runtime key={data} props={data} ></fui-product-apis-runtime>
: this.state.layout === 'tiles'
? <product-apis-tiles-runtime params={data}></product-apis-tiles-runtime>
: <product-apis-runtime params={data}></product-apis-runtime>;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export class ProductListViewModel extends React.Component {
const data = JSON.stringify(this.state);

return this.state.isRedesignEnabled
? <fui-product-list-runtime props={data} ></fui-product-list-runtime>
? <fui-product-list-runtime key={data} props={data} ></fui-product-list-runtime>
: this.state.layout === 'tiles'
? <product-list-tiles-runtime params={data}></product-list-tiles-runtime>
: this.state.layout === 'dropdown'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export class ProductSubscribeViewModel extends React.Component {
const data = JSON.stringify(this.state);

return this.state.isRedesignEnabled
? <fui-product-subscribe-runtime props={data} ></fui-product-subscribe-runtime>
? <fui-product-subscribe-runtime key={data} props={data} ></fui-product-subscribe-runtime>
: <product-subscribe-runtime params={data}></product-subscribe-runtime>;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,9 @@ export class ChangePasswordViewModel extends React.Component{
}

public render(): JSX.Element {
const data = JSON.stringify(this.state);
return this.state.isRedesignEnabled
? <fui-change-password props={JSON.stringify(this.state)} ></fui-change-password>
: <change-password-runtime params={JSON.stringify(this.state)}></change-password-runtime>;
? <fui-change-password key={data} props={data} ></fui-change-password>
: <change-password-runtime params={data}></change-password-runtime>;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,9 @@ export class ResetPasswordViewModel extends React.Component{
}

public render(): JSX.Element {
const data = JSON.stringify(this.state);
return this.state.isRedesignEnabled
? <fui-reset-password props={JSON.stringify(this.state)} ></fui-reset-password>
: <reset-password-runtime params={JSON.stringify(this.state)}></reset-password-runtime>;
? <fui-reset-password key={data} props={data} ></fui-reset-password>
: <reset-password-runtime params={data}></reset-password-runtime>;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,10 @@ export class SignUpSocialViewModel extends React.Component {
}
return <placeholder-content></placeholder-content>;
}
const data = JSON.stringify(this.state);

return this.state.isRedesignEnabled
? <fui-signup-aad-runtime props={JSON.stringify(this.state)}></fui-signup-aad-runtime>
: <signup-social-runtime params={JSON.stringify(this.state)}></signup-social-runtime>;
? <fui-signup-aad-runtime key={data} props={data}></fui-signup-aad-runtime>
: <signup-social-runtime params={data}></signup-social-runtime>;
}
}
4 changes: 3 additions & 1 deletion src/components/users/signup/react/SignUpViewModel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@ export class SignUpViewModel extends React.Component {
}

public render(): JSX.Element {
const data = JSON.stringify(this.state);

return this.state.isRedesignEnabled
? <fui-signup-runtime props={JSON.stringify(this.state)} ></fui-signup-runtime>
? <fui-signup-runtime key={data} props={data} ></fui-signup-runtime>
: <signup-runtime params={JSON.stringify(this.state)}></signup-runtime>;
}
}