Skip to content

Made several Admin UI left nav items keyboard accessible #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Made several Admin UI left nav items keyboard accessible #2660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/admin/custom-widgets/customWidgets.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,18 @@ export class CustomWidgets extends React.Component<CustomWidgetsProps, CustomWid
title="Edit"
style={iconStyles}
className="nav-item-inner"
tabIndex={0}
onClick={(event) => {
this.setState({ showCustomWidgetModal: true, selectedCustomWidget: customWidget });
event.stopPropagation();
this.setState({ showCustomWidgetModal: true, selectedCustomWidget: customWidget })}
}
}}
// Required for accessibility
onKeyDown={(event) => {
if (event.key === 'Enter') {
this.setState({ showCustomWidgetModal: true, selectedCustomWidget: customWidget });
event.preventDefault();
}
}}
/>
</Stack>
)
Expand Down
28 changes: 22 additions & 6 deletions src/admin/pages/pages.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,18 +105,25 @@ export class Pages extends React.Component<PagesProps, PagesState> {
horizontalAlign="space-between"
verticalAlign="center"
className="nav-item-outer-stack"
onClick={async () => await this.router.navigateTo(page.permalink)}
>
<Text>{page.title}</Text>
<FontIcon
iconName="Settings"
title="Edit"
style={iconStyles}
className="nav-item-inner"
tabIndex={0}
onClick={(event) => {
this.setState({ showPagesModal: true, selectedPage: page });
event.stopPropagation();
this.setState({ showPagesModal: true, selectedPage: page })}
}
}}
// Required for accessibility
onKeyDown={(event) => {
if (event.key === 'Enter') {
this.setState({ showPagesModal: true, selectedPage: page });
event.preventDefault();
}
}}
/>
</Stack>
)
Expand All @@ -127,18 +134,25 @@ export class Pages extends React.Component<PagesProps, PagesState> {
horizontalAlign="space-between"
verticalAlign="center"
className="nav-item-outer-stack"
onClick={async () => this.viewManager.setHost({ name: 'layout-host', params: { layoutKey: layout.key } })}
>
<Text block nowrap className="nav-item-title">{layout.title}</Text>
<FontIcon
iconName="Settings"
title="Edit"
style={iconStyles}
className="nav-item-inner"
tabIndex={0}
onClick={(event) => {
this.setState({ showLayoutModal: true, selectedLayout: layout });
event.stopPropagation();
this.setState({ showLayoutModal: true, selectedLayout: layout })}
}
}}
// Required for accessibility
onKeyDown={(event) => {
if (event.key === 'Enter') {
this.setState({ showLayoutModal: true, selectedLayout: layout });
event.preventDefault();
}
}}
/>
</Stack>
)
Expand Down Expand Up @@ -188,6 +202,7 @@ export class Pages extends React.Component<PagesProps, PagesState> {
key={page.key}
className="nav-item-list-button"
onRenderText={() => this.renderPageContent(page)}
onClick={async () => await this.router.navigateTo(page.permalink)}
/>
)}
</div>
Expand Down Expand Up @@ -218,6 +233,7 @@ export class Pages extends React.Component<PagesProps, PagesState> {
key={layout.key}
className="nav-item-list-button"
onRenderText={() => this.renderPageLayoutContent(layout)}
onClick={async () => this.viewManager.setHost({ name: 'layout-host', params: { layoutKey: layout.key } })}
/>
)}
</div>
Expand Down
12 changes: 10 additions & 2 deletions src/admin/popups/popups.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,18 @@ export class Popups extends React.Component<PopupsProps, PopupsState> {
title="Edit"
style={iconStyles}
className="nav-item-inner"
tabIndex={0}
onClick={(event) => {
this.setState({ showPopupDetailsModal: true, selectedPopup: popup });
event.stopPropagation();
this.setState({ showPopupDetailsModal: true, selectedPopup: popup })}
}
}}
// Required for accessibility
onKeyDown={(event) => {
if (event.key === 'Enter') {
this.setState({ showPopupDetailsModal: true, selectedPopup: popup });
event.preventDefault();
}
}}
/>
</Stack>
)
Expand Down
12 changes: 10 additions & 2 deletions src/admin/urls/urls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,18 @@ export class Urls extends React.Component<UrlsProps, UrlsState> {
title="Edit"
style={iconStyles}
className="nav-item-inner"
tabIndex={0}
onClick={(event) => {
this.setState({ showUrlDetailsModal: true, selectedUrl: url });
event.stopPropagation();
this.setState({ showUrlDetailsModal: true, selectedUrl: url })}
}
}}
// Required for accessibility
onKeyDown={(event) => {
if (event.key === 'Enter') {
this.setState({ showUrlDetailsModal: true, selectedUrl: url });
event.preventDefault();
}
}}
/>
</Stack>
)
Expand Down
4 changes: 4 additions & 0 deletions src/themes/designer/styles/admin.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,10 @@

.nav-item-inner {
opacity: 0;

&:focus {
opacity: 1;
}
}

&:hover {
Expand Down
Loading