Ashishonce/multiplepruns #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishonce
commented
Apr 23, 2020
| print(f"::set-output name=run_metrics::{run_metrics}") | ||
| print(f"::set-output name=run_metrics_markdown::{run_metrics_markdown}") | ||
| submittedRuns_for_wait.remove(run) | ||
| time.sleep(10) # wait for 10 seconds to check again. |
Member
Author
There was a problem hiding this comment.
this wait time is point of check, do we wait for 10 seconds before checking status again?
Contributor
There was a problem hiding this comment.
Given runs can be quite long, this seems reasonable. @marvinbuss thoughts?
2 tasks
marvinbuss
requested changes
May 1, 2020
Contributor
marvinbuss
left a comment
marvinbuss
left a comment
There was a problem hiding this comment.
Before merging this:
- Add integration tests
- Describe features in Readme
Member
Author
will work on this PR once integration tests in other PR are checked in , will merge with that and update this PR |
Contributor
Yes, let's focus on integration test and the other missing pieces for the next 2 weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR supports multiple runs, but with for loop instead of multiprocessing.
this has drawback over multiprocessing as it has a deterministic delay when multiple runs might be submitted.