Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore sync errors from zap upon exit #68

Merged
merged 2 commits into from
Apr 11, 2024
Merged

fix: ignore sync errors from zap upon exit #68

merged 2 commits into from
Apr 11, 2024

Conversation

cameronmeissner
Copy link
Contributor

zap logger sync errors are polluting client output on both linux and macOS platforms, per guidance laid out here: uber-go/zap#328 (comment)

@cameronmeissner cameronmeissner changed the title Cameissner/ignore zap sync fix: ignore sync errors from zap upon exit Apr 11, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8652525955

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.72%
Totals Coverage Status
Change from base Build 8652359982: 0.0%
Covered Lines: 381
Relevant Lines: 472
💛 - Coveralls

@cameronmeissner cameronmeissner merged commit 4f44b42 into main Apr 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlisonB319 AlisonB319 AlisonB319 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cameronmeissner @coveralls @AlisonB319