Feature/kubectl to client go #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaud-tincelin
commented
Aug 2, 2021
arnaud-tincelin
commented
Aug 4, 2021
arnaud-tincelin
commented
Aug 4, 2021
Tatsinnit
force-pushed
the
feature/kubectl-to-client-go
branch
from
8590711
to
1e3b164
Compare
Tatsinnit
reviewed
Aug 6, 2021
Tatsinnit
force-pushed
the
feature/kubectl-to-client-go
branch
from
ac212f5
to
bb0e00e
Compare
arnaud-tincelin
commented
Aug 7, 2021
Tatsinnit
force-pushed
the
feature/kubectl-to-client-go
branch
from
3d37ca2
to
b5b19a3
Compare
|
I can't approve this PR @Tatsinnit because I opened it ... But this message will do. Feel free to merge! |
Tatsinnit
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the
client-goimplementation and move away fromos.exec-kubectlexecution. That way we will be able to remove theos.execdependency andkubectl binaryin docker image.please note: due to the way client-go objects work in order to form the CPU% I need to identify total cores etc, which is not part of this PR, will be awesomee to get some thoughts on that as well please. thanks guys.
system-err_collectorand tends to move it away from directkubectlimplementation toclient-goimplementation.client-gosource code.Thanks, 🙏 ^Tats
Opening this for wider opinion and suggestions.
cc: @arnaud-tincelin , @davidkydd, @JunSun17 and anyone interested, Thanks
Any new collectors should spend time doing this way.