Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CRD bug #86

Merged
merged 2 commits into from
Jul 21, 2021
Merged

fix CRD bug #86

merged 2 commits into from
Jul 21, 2021

Conversation

Tatsinnit
Copy link
Member

@Tatsinnit Tatsinnit commented Jul 20, 2021

This PR captures fix under this PR: #82 for the CRD fix. (in more succinct form and the refactor to use singleton is done using sync.once.do in PR #85 )

Thanks.,

cc: @arnaud-tincelin , @davidkydd

@Tatsinnit Tatsinnit changed the title fix CRD REadme bug fix CRD bug Jul 20, 2021
@Tatsinnit Tatsinnit self-assigned this Jul 20, 2021
@Tatsinnit Tatsinnit requested a review from JunSun17 July 20, 2021 07:48
pkg/utils/helper.go Outdated Show resolved Hide resolved
@Tatsinnit Tatsinnit requested a review from davidkydd July 20, 2021 09:32
Copy link
Collaborator

@davidkydd davidkydd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Tatsinnit Tatsinnit merged commit 2ea86f0 into Azure:master Jul 21, 2021
@Tatsinnit Tatsinnit linked an issue Jul 21, 2021 that may be closed by this pull request
@Tatsinnit Tatsinnit deleted the fix-for-CRD branch September 2, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diagnoser WriteToCrd broken during recent refactor
2 participants