reverse the kind vs. non-kind check to be AKS vs. non-AKS

pkg/exporter/azureblob_exporter.go

@@ -39,26 +39,28 @@ func NewAzureBlobExporter() *AzureBlobExporter {
 func (exporter *AzureBlobExporter) GetStorageContainerName(APIServerFQDN string) (string, error) {
 	var containerName string
 	var err error
-	if utils.IsKubernetesInDocker() {
-		containerName, err = exporter.GetKubernetesInDockerStorageContainerName(APIServerFQDN)
+	if utils.IsRunningInAks() {
+		containerName, err = exporter.GetAKSStorageContainerName(APIServerFQDN)
 	} else {
-		containerName, err = exporter.GetNonKINDStorageContainerName(APIServerFQDN)
+		containerName, err = exporter.GetNonAKSStorageContainerName(APIServerFQDN)
 	}
 
 	//TODO run a sanitizer over the final chars in the containerName
 	return containerName, err
 }
 
-func (exporter *AzureBlobExporter) GetKubernetesInDockerStorageContainerName(APIServerFQDN string) (string, error) {
+//GetNonAKSStorageContainerName get the storage container name for non AKS cluster
+func (exporter *AzureBlobExporter) GetNonAKSStorageContainerName(APIServerFQDN string) (string, error) {
 	containerName := strings.Replace(APIServerFQDN, ".", "-", -1)
 
 	return containerName, nil
 }
 
-func (exporter *AzureBlobExporter) GetNonKINDStorageContainerName(APIServerFQDN string) (string, error) {
+//GetAKSStorageContainerName get the storage container name when running on an AKS cluster
+func (exporter *AzureBlobExporter) GetAKSStorageContainerName(APIServerFQDN string) (string, error) {
 	containerName := strings.Replace(APIServerFQDN, ".", "-", -1)
 
-	//TODO I really dont like the line below, it makes for weird behaviour if e.g. .hcp. or -hcp- is in the fqdn for some reason other than being auto-added by AKS
+	//TODO DK: I really dont like the line below, it makes for weird behaviour if e.g. .hcp. or -hcp- is in the fqdn for some reason other than being auto-added by AKS
 	length := strings.Index(containerName, "-hcp-")
 
 	if length == -1 {

pkg/exporter/azureblob_exporter_test.go

@@ -15,12 +15,12 @@ var getStorageContainerNameTests = []struct {
 	{"extra.super.duper.long.apiserverfqdn.that.has.more.than.63.characters", "extra-super-duper-long-apiserverfqdn-that-has-more-than-63-char"},
 }
 
-// TestGetNonKINDStorageContainerName get storage container name for non kind cluster
-func TestGetNonKINDStorageContainerName(t *testing.T) {
+// TestGetAKSStorageContainerName get storage container name for non kind cluster
+func TestGetAKSStorageContainerName(t *testing.T) {
 	for _, tt := range getStorageContainerNameTests {
 		t.Run(tt.apiServerFqdn, func(t *testing.T) {
 			var blobExporter = &AzureBlobExporter{}
-			containerName, _ := blobExporter.GetNonKINDStorageContainerName(tt.apiServerFqdn)
+			containerName, _ := blobExporter.GetAKSStorageContainerName(tt.apiServerFqdn)
 
 			if containerName != tt.containerName {
 				t.Errorf("Sprintf(%q, &blobExporter) => %q, want %q",