Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hack to prevent the program from exiting #66

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Hack to prevent the program from exiting #66

merged 1 commit into from
Jun 9, 2021

Conversation

arnaud-tincelin
Copy link
Collaborator

No description provided.

@arnaud-tincelin arnaud-tincelin force-pushed the hack-stop branch 3 times, most recently from ef1fdd7 to 7052ec7 Compare June 9, 2021 10:26
Tatsinnit
Tatsinnit approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 I see this existed since day 1 of this code :

aks-periscope/cmd/aks-periscope/aks-periscope.go

Line 70 in b98d66a

select {}

Good to catch this and add it back with comments for future reference and understanding.

Thanks.

@Tatsinnit Tatsinnit merged commit 6355065 into Azure:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tatsinnit Tatsinnit Tatsinnit approved these changes

@JunSun17 JunSun17 Awaiting requested review from JunSun17

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnaud-tincelin @Tatsinnit