fix azure blob exporter #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaud-tincelin
force-pushed
the
fix-storage-exporter
branch
2 times, most recently
from
251c430
to
196fe00
Compare
arnaud-tincelin
force-pushed
the
fix-storage-exporter
branch
from
196fe00
to
a26519c
Compare
Tatsinnit
reviewed
Jun 3, 2021
| pipeline := azblob.NewPipeline(azblob.NewAnonymousCredential(), azblob.PipelineOptions{}) | ||
| accountName := os.Getenv("AZURE_BLOB_ACCOUNT_NAME") | ||
| sasKey := os.Getenv("AZURE_BLOB_SAS_KEY") | ||
| cred, err := azblob.NewSharedKeyCredential(accountName, sasKey) |
There was a problem hiding this comment.
💡 Question: will this work with sasKeyy seems like it is used with accountKey passed,?
-
doc'd here: https://pkg.go.dev/github.com/Azure/azure-storage-blob-go/azblob
-
https://github.com/Azure/azure-storage-blob-go/blob/v0.13.0/azblob/zc_credential_shared_key.go#L21
There was a problem hiding this comment.
Indeed, it will not work with a SAS key, I will close the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 404 error on azure blob exporter