Dockerfile cleanup & fix deployment

[arnaud-tincelin]

• cleanup dockerfile & use ENTRYPOINT
• fix mount paths

[Tatsinnit]

👍 Looks good, thanks.

I will give it a test from this fork tomorrow, also fyi: @JunSun17 - for name changes and if he can see any other impact.

[Tatsinnit]

💡 looks good, tested with these changes, with following image: tatsat/docker-changes , thanks.

[Tatsinnit]

💡 THanks for this, just added one small comment as a note as to what we learned few mins back :)

[Tatsinnit]

💡 looks good, I will give a quick local test and merge it in few hours. Thank you for this.

[Tatsinnit]

💡 Update: Something went wrong and I am still investigating but here is the image created of this branch: tatsat/docker-changes - it constantly cause failure, and logs are empty so something before that went wrong.

[Tatsinnit]

🐛 I think . lets the bash to identify and run, or might be the entry point below needs a mechanism to tell / to run with bash.

Working image with below change: tatsat/docker-changes-test

Fix \ Solution

COPY --from=builder /build/aks-periscope .

ENTRYPOINT ["./aks-periscope"]

[Tatsinnit]

💡 quick question: Just checking for this copy the source and destination is same?

[Tatsinnit]

👍 Ok, make sense this is directly associated with the new kustomisation approach and we need to involve az-cli and vscode before we do major release.

If not, we always have option of .. 📓

Thanks @arnaud-tincelin for contribution.