Add support for Kubernetes 1.12.4 #82
Conversation
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
=======================================
Coverage 55.45% 55.45%
=======================================
Files 109 109
Lines 16054 16054
=======================================
Hits 8903 8903
Misses 6368 6368
Partials 783 783 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
=======================================
Coverage 55.45% 55.45%
=======================================
Files 109 109
Lines 16054 16054
=======================================
Hits 8903 8903
Misses 6368 6368
Partials 783 783 |
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
==========================================
+ Coverage 53.16% 53.16% +<.01%
==========================================
Files 95 95
Lines 14230 14228 -2
==========================================
Hits 7565 7565
+ Misses 5997 5995 -2
Partials 668 668 |
mboersma
changed the title
mboersma
force-pushed
the
k8s-1.12.3
branch
2 times, most recently
from
4c6ebbe to
4d8eb18
Compare
pkg/api/k8s_versions.go
Outdated
| @@ -30,7 +30,7 @@ var k8sComponentVersions = map[string]map[string]string{ | |||
| "aci-connector": "virtual-kubelet:latest", | |||
| ContainerMonitoringAddonName: "oms:ciprod10162018-2", | |||
| AzureCNINetworkMonitoringAddonName: "networkmonitor:v0.0.4", | |||
| "cluster-autoscaler": "cluster-autoscaler:v1.3.3", | |||
| "cluster-autoscaler": "cluster-autoscaler:v1.12.1", | |||
There was a problem hiding this comment.
Is there a good reason for including this change in this PR?
There was a problem hiding this comment.
I just bump components when Kubernetes release notes say to do so, and this big jump was recommended in v1.12.3: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.12.md#changelog-since-v1122
Update Cluster Autoscaler to 1.12.1 (#70705, @losipiuk)
The new versioning is outlined here: https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler#releases
There was a problem hiding this comment.
I see. The reason I'm confused is because as implemented here we're bumping cluster-autoscaler in 1.13 only.
There was a problem hiding this comment.
That seems incorrect then. Should be 1.12.x for 1.12.x and 1.13.x for 1.13... I'll fix it up.
There was a problem hiding this comment.
I fixed this--thanks for noticing! cluster-autoscaler v1.12.1 appears to be the current 1.12.x release, so I left it there.
|
/lgtm |
|
New changes are detected. LGTM label has been removed. |
|
/lgtm post-rebase |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add support for Kubernetes 1.12.3 See https://github.com/kubernetes/kubernetes/releases/tag/v1.12.3 * Bump cluster-autoscaler to recommended version for 1.12.3 * Bump to k8s 1.12.4 See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.12.md#v1124 * Move cluster-autoscaler bump to correct stanza * enable 20 mins for HPA scale down
What this PR does / why we need it:
See https://github.com/kubernetes/kubernetes/releases/tag/v1.12.4
Refs #73.
TODO:
If applicable:
Release note: