Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

Remove Windows Docker VHD build check #5104

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

CecileRobertMichon
Copy link
Contributor

Reason for Change:

Docker VHD is deprecated, removes the test build to get rid of failures in PRs

azure-arm: Find-Package : No match was found for the specified search criteria and package name 'Docker'

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

mboersma
mboersma previously approved these changes Aug 15, 2023
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marosset
Copy link
Contributor

Can you update https://github.com/Azure/aks-engine/blob/master/.pipelines/vhd-build-publish-windows.yaml and remove the build_2019_docker and publish_2019_docker stages too?

Copy link
Contributor

@marosset marosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CecileRobertMichon CecileRobertMichon merged commit ed867bb into Azure:master Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants