This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
Remove unnecessary npm tests in kubernetes e2e test #4979
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csfmomo
changed the title
csfmomo
changed the title
estebancams
approved these changes
Oct 18, 2022
|
Hi, @csfmomo & @estebancams - can you help me understand why this change is needed? As I understand it, we are moving away from AKS Engine for upstream Kubernetes testing. We are using CAPZ and AKS. See kubernetes-sigs/cloud-provider-azure#1929 for more details. |
|
@csfmomo this PR has been sitting here a while without any activity, so I'm going to close it. AKS Engine is in maintenance mode, so we try to keep the PR queue clear to be consistent with that messaging. If I'm wrong and this is still needed, please do reopen it and let us know the status. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary npm tests in kubernetes e2e test. All of the tests can be covered by comformance test in NPM for ACN.
Reason for Change:
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: