Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

docs: Remove double quotes(") at quickstart.md #3967

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

mysticrenji
Copy link
Contributor

-> run aks-engine deploy example script contains unwanted (") at Line number 84 of Quickstart.md, which causes syntax error. I have tried the script after truncating " and it runs successfully.

Reason for Change:
run aks-engine deploy example script contains unwanted (") at Line number 84 of Quickstart.md, which causes syntax error. I have tried the script after truncating " and it runs successfully.

Issue Fixed:
Cosmetic changes in the Quickstart.md

Credit Where Due:

Does this change contain code from or inspired by another project?

  • [X ] No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • [X ] No
  • Yes

Requirements:

Notes:

-> run `aks-engine deploy` example script contains unwanted (") at Line number 84 of Quickstart.md, which causes syntax error. I have tried the script after truncating " and  it runs successfully.
@welcome
Copy link

welcome bot commented Oct 24, 2020

💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - fix: change azure disk cachingMode to ReadOnly - feat: make maximumLoadBalancerRuleCount configurable - docs: add note on AKS Engine and AKS relationship
Make sure to check out the developer guide for guidance on testing your change.

@mysticrenji mysticrenji changed the title Remove double quotes(") at the aks-deploy sample fix: Remove double quotes(") at quickstart.md Oct 24, 2020
@mysticrenji
Copy link
Contributor Author

/assign @ritazh

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Oct 26, 2020
@jackfrancis jackfrancis changed the title fix: Remove double quotes(") at quickstart.md docs: Remove double quotes(") at quickstart.md Oct 26, 2020
@jackfrancis
Copy link
Member

Thx @mysticrenji!

@jackfrancis jackfrancis merged commit e933521 into Azure:master Oct 26, 2020
@welcome
Copy link

welcome bot commented Oct 26, 2020

Congrats on merging your first pull request! 🎉🎉🎉

@acs-bot
Copy link

acs-bot commented Oct 26, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mysticrenji

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants