fix: primary scale set name

[CJJ69]

Reason for Change:

VM Scale Set name used is incorrect for Windows agent pool, cluster auto scaler fails.

Azure/acs-engine#4055

Issue Fixed:

Fixes #209

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• tested upgrade from previous version

Notes:
Tested on Azure. Creating Windows agent pool with "availabilityProfile": "VirtualMachineScaleSets"

[welcome]

💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - fix: change azure disk cachingMode to ReadOnly - feat: make maximumLoadBalancerRuleCount configurable - docs: add note on AKS-Engine and AKS relationship
Make sure to check out the developer guide for guidance on testing your change.

[acs-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: CJJ69
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jackfrancis

If they are not already assigned, you can assign the PR to them by writing /assign @jackfrancis in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[CJJ69]

/assign @jackfrancis

[jackfrancis]

@PatrickLang can you take a look at this?

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[mboersma]

@CJJ69 sorry this has been sitting so long--it needs a rebase now.

@PatrickLang could you take a look at this Windows fix?

[CJJ69]

This issue occurs if Windows vmss is specified as first pool in agentPoolProfiles. Then the variable for primaryScaleSetName does not match actual Windows ScaleSet ID.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.