This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: use explicit kubeconfig in label-nodes.sh #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2929 +/- ##
=========================================
Coverage ? 72.49%
=========================================
Files ? 141
Lines ? 25847
Branches ? 0
=========================================
Hits ? 18739
Misses ? 6021
Partials ? 1087 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Fixes this script so it works in Kubernetes 1.18.0-rc.1 (and others), now that
kubectldoesn't find a default config as we assumed before.Issue Fixed:
See #2923
See kubernetes-sigs/windows-testing#141
Requirements:
Notes:
This change to
label-nodes.shisn't actually being tested in this PR since it's skipped over in VHD deploys, but the hacky commits in #2923 did test and validate this change.