This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: Add IsCredentialAutoGenerated for WindowsProfile #2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
marosset
reviewed
Feb 28, 2020
Codecov Report
@@ Coverage Diff @@
## master #2804 +/- ##
==========================================
+ Coverage 72.35% 72.43% +0.08%
==========================================
Files 137 140 +3
Lines 25339 25552 +213
==========================================
+ Hits 18333 18508 +175
- Misses 5949 5976 +27
- Partials 1057 1068 +11
Continue to review full report at Codecov.
|
AbelHu
force-pushed
the
add_win_auto_gen
branch
from
330709b to
7c0846d
Compare
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
marosset
approved these changes
Mar 2, 2020
AbelHu
added a commit
to AbelHu/aks-engine
that referenced
this pull request
Mar 3, 2020
AbelHu
added a commit
to AbelHu/aks-engine
that referenced
this pull request
Mar 3, 2020
xuto2
pushed a commit
that referenced
this pull request
Mar 3, 2020
andyliuliming
pushed a commit
that referenced
this pull request
Mar 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
AKS plans to auto generate Windows username and password if Windows agent pools can be added to this cluster later. We need to distinguish that the Windows credential is set by users from that the Windows credential is auto generated.
Issue Fixed:
Requirements:
Notes: