test: crash docker and validate against common node count #1946
Conversation
| @@ -940,7 +940,7 @@ var _ = Describe("Azure Container Cluster using the Kubernetes Orchestrator", fu | |||
|
|
|||
| var expectedReadyNodes int | |||
| if !eng.ExpandedDefinition.Properties.HasLowPriorityScaleset() { | |||
| expectedReadyNodes = eng.NodeCount() | |||
There was a problem hiding this comment.
By setting this expected count against the value in the api model, we don't take into account that the list we enumerate through in line 918 above may not have the exact same numbers due to environmental behaviors. Because we are specifically testing docker crash simulation in this test, we want to make sure the node count before and after operate against a common number of nodes.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #1946 +/- ##
=======================================
Coverage 76.67% 76.67%
=======================================
Files 135 135
Lines 20536 20536
=======================================
Hits 15745 15745
Misses 3873 3873
Partials 918 918 |
Reason for Change:
We are running docker crash simulations against a list of nodes whose length we determine at the time the test runs. We also need to do all validations against that common list.
Issue Fixed:
Requirements:
Notes: