-
Notifications
You must be signed in to change notification settings - Fork 521
Conversation
@ritazh Can we add one pre-pull scripts for the kms docker image in the packer shell scripts? |
@tariq1890 the
So I don't think this image should be added there. |
That's for the VHD so that the images are pre-pulled. Any VM that is created off of the VHD will already have that docker image in its local registry. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ritazh, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
==========================================
- Coverage 53.14% 53.11% -0.03%
==========================================
Files 95 95
Lines 14216 14188 -28
==========================================
- Hits 7555 7536 -19
+ Misses 5992 5981 -11
- Partials 669 671 +2 |
2 similar comments
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
==========================================
- Coverage 53.14% 53.11% -0.03%
==========================================
Files 95 95
Lines 14216 14188 -28
==========================================
- Hits 7555 7536 -19
+ Misses 5992 5981 -11
- Partials 669 671 +2 |
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
==========================================
- Coverage 53.14% 53.11% -0.03%
==========================================
Files 95 95
Lines 14216 14188 -28
==========================================
- Hits 7555 7536 -19
+ Misses 5992 5981 -11
- Partials 669 671 +2 |
* Add hsm support for kms plugin * Update install dependencies script
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
If applicable:
Release note: