Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

Add HSM support for kms encryption #157

Merged
merged 2 commits into from
Dec 18, 2018
Merged

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Dec 17, 2018

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

@acs-bot acs-bot added the size/S label Dec 17, 2018
@tariq1890
Copy link
Contributor

@ritazh Can we add one pre-pull scripts for the kms docker image in the packer shell scripts?

Here: https://github.com/Azure/aks-engine/blob/b8f75fdff2e3d9b48e5480acc27a585efae0fed5/packer/install-dependencies.sh

@ritazh
Copy link
Member Author

ritazh commented Dec 17, 2018

@tariq1890 the microsoft/k8s-azure-kms:v0.0.7 image is being pulled by the azure kms systemd service, not as part of the install-dependencies.sh script.

microsoft/k8s-azure-kms:v0.0.7

So I don't think this image should be added there.

@tariq1890
Copy link
Contributor

That's for the VHD so that the images are pre-pulled. Any VM that is created off of the VHD will already have that docker image in its local registry.

@tariq1890
Copy link
Contributor

/lgtm

@acs-bot
Copy link

acs-bot commented Dec 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ritazh, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #157 into master will decrease coverage by 0.02%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   53.14%   53.11%   -0.03%     
==========================================
  Files          95       95              
  Lines       14216    14188      -28     
==========================================
- Hits         7555     7536      -19     
+ Misses       5992     5981      -11     
- Partials      669      671       +2

2 similar comments
@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #157 into master will decrease coverage by 0.02%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   53.14%   53.11%   -0.03%     
==========================================
  Files          95       95              
  Lines       14216    14188      -28     
==========================================
- Hits         7555     7536      -19     
+ Misses       5992     5981      -11     
- Partials      669      671       +2

@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #157 into master will decrease coverage by 0.02%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   53.14%   53.11%   -0.03%     
==========================================
  Files          95       95              
  Lines       14216    14188      -28     
==========================================
- Hits         7555     7536      -19     
+ Misses       5992     5981      -11     
- Partials      669      671       +2

@tariq1890 tariq1890 merged commit 9254901 into Azure:master Dec 18, 2018
juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
* Add hsm support for kms plugin

* Update install dependencies script
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants