This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
use a fixed version for flex addons #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyzhangx
changed the title
3 tasks
|
/lgtm pending E2E |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
=======================================
Coverage 53.14% 53.14%
=======================================
Files 95 95
Lines 14216 14216
=======================================
Hits 7555 7555
Misses 5992 5992
Partials 669 669 |
2 similar comments
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
=======================================
Coverage 53.14% 53.14%
=======================================
Files 95 95
Lines 14216 14216
=======================================
Hits 7555 7555
Misses 5992 5992
Partials 669 669 |
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
=======================================
Coverage 53.14% 53.14%
=======================================
Files 95 95
Lines 14216 14216
=======================================
Hits 7555 7555
Misses 5992 5992
Partials 669 669 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
use fixed version for flex volume drivers
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #151Special notes for your reviewer:
If applicable:
Release note:
@CecileRobertMichon
You could find all
blobfuseimage versions here:https://github.com/Azure/kubernetes-volume-drivers/tree/master/flexvolume/blobfuse/deployment#blobfuse-flexvol-installer-image-release-notes
From now on, we only use
1.0.7blobfuse version, so you may only need to incorporate1.0.7version in the Ubuntu image.And you could find all
smbimage versions here:https://github.com/Azure/kubernetes-volume-drivers/tree/master/flexvolume/smb/deployment#smb-flexvol-installer-image-release-notes
smbdriver is disabled in acs-engine, so it's not necessary to make it built-in in the Ubuntu image.