Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

Quick documentation rationalization #152

Merged
merged 2 commits into from
Dec 14, 2018

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented Dec 14, 2018

What this PR does / why we need it: Does some s/acs-engine/aks-engine duties, and eliminates the "under construction" nature of the front page docs.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

Quick documentation rationalization

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Dec 14, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acs-bot
Copy link

acs-bot commented Dec 14, 2018

New changes are detected. LGTM label has been removed.

@acs-bot acs-bot removed the lgtm label Dec 14, 2018
@jackfrancis jackfrancis merged commit 552b6eb into Azure:master Dec 14, 2018
@jackfrancis jackfrancis deleted the front-page-docs branch December 14, 2018 23:52
jackfrancis added a commit that referenced this pull request Dec 14, 2018
@codecov
Copy link

codecov bot commented Dec 15, 2018

Codecov Report

Merging #152 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   53.07%   53.07%           
=======================================
  Files          95       95           
  Lines       14200    14200           
=======================================
  Hits         7536     7536           
  Misses       5993     5993           
  Partials      671      671

3 similar comments
@codecov
Copy link

codecov bot commented Dec 15, 2018

Codecov Report

Merging #152 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   53.07%   53.07%           
=======================================
  Files          95       95           
  Lines       14200    14200           
=======================================
  Hits         7536     7536           
  Misses       5993     5993           
  Partials      671      671

@codecov
Copy link

codecov bot commented Dec 15, 2018

Codecov Report

Merging #152 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   53.07%   53.07%           
=======================================
  Files          95       95           
  Lines       14200    14200           
=======================================
  Hits         7536     7536           
  Misses       5993     5993           
  Partials      671      671

@codecov
Copy link

codecov bot commented Dec 15, 2018

Codecov Report

Merging #152 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   53.07%   53.07%           
=======================================
  Files          95       95           
  Lines       14200    14200           
=======================================
  Hits         7536     7536           
  Misses       5993     5993           
  Partials      671      671

juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants