-
Notifications
You must be signed in to change notification settings - Fork 521
Conversation
|
||
**Describe alternatives you've considered** | ||
|
||
**Additional context** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add something like "why is this needed" , ie. convince us that we want this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's important, so I added it as the second section in feature request template.
Kubernetes also has failing test and support. It's pretty cool that we can customize these to add specific categories. Do you think having a support or question category is overkill? I guess for those people can use the "regular issue" button. https://github.com/kubernetes/kubernetes/tree/master/.github/ISSUE_TEMPLATE |
@@ -1,42 +0,0 @@ | |||
<!-- Thanks for filing an issue! Before hitting the button, please answer these questions. It's helpful to search the existing GitHub issues first. It's likely that another user has already reported the issue you're facing, or it's a known issue that we're already aware of--> | |||
|
|||
**Is this a request for help?**: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking forward to getting rid of this... I don't think I've ever seen someone answer "no" to "Is this a request for help?"
Not necessarily—I almost added a "question" template when creating this. Maybe for now we use "bug," "feature," and the "regular issue" link and see how it goes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## master #1382 +/- ##
======================================
Coverage 75.5% 75.5%
======================================
Files 128 128
Lines 18141 18141
======================================
Hits 13697 13697
Misses 3641 3641
Partials 803 803 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
Adds separate issue and feature issue templates initially generated by the GH wizard. These should be more targeted and less verbose, but I would love feedback on how to make them more user-friendly.
Issue Fixed:
Fixes #1381
Requirements:
Notes: