-
Notifications
You must be signed in to change notification settings - Fork 521
fix: add UDP Standard LB rule to enable outbound access #1155
fix: add UDP Standard LB rule to enable outbound access #1155
Conversation
should this be a |
Codecov Report
@@ Coverage Diff @@
## master #1155 +/- ##
==========================================
+ Coverage 74.87% 74.88% +0.01%
==========================================
Files 131 131
Lines 18428 18517 +89
==========================================
+ Hits 13798 13867 +69
- Misses 3837 3857 +20
Partials 793 793 |
@ritazh can you kindly do a functional review? In a nutshell, in order to enable outbound UDP on masters + nodes in a standard LB-enabled cluster, that cluster will have the requirement of 4 external IP addresses, one each for UDP and TCP per LB (one LB for masters one LB for nodes). I've confirmed that this PR fulfills the requirement of enabling TCP and UDP outbound (in particular, the obvious symptom this fixes is to enable ntp time sync on masters and nodes). |
lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
Azure Standard Load Balancers do not grant outbound access by default to backend VMs by default. This PR adds a UDP LB rule to the Standard LB spec to enable UDP outbound internet access on master VMs behind a Standard LB.
Additionally, added a UDP svc spec to enable UDP outbound for nodes.
Fixes #1099
Fixes #1125
Issue Fixed:
Requirements:
Notes: