Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: add UDP Standard LB rule to enable outbound access #1155

Merged
merged 3 commits into from
Apr 26, 2019

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented Apr 25, 2019

Reason for Change:

Azure Standard Load Balancers do not grant outbound access by default to backend VMs by default. This PR adds a UDP LB rule to the Standard LB spec to enable UDP outbound internet access on master VMs behind a Standard LB.

Additionally, added a UDP svc spec to enable UDP outbound for nodes.

Fixes #1099
Fixes #1125

Issue Fixed:

Requirements:

Notes:

@CecileRobertMichon
Copy link
Contributor

should this be a fix: ?

@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #1155 into master will increase coverage by 0.01%.
The diff coverage is 68.75%.

@@            Coverage Diff             @@
##           master    #1155      +/-   ##
==========================================
+ Coverage   74.87%   74.88%   +0.01%     
==========================================
  Files         131      131              
  Lines       18428    18517      +89     
==========================================
+ Hits        13798    13867      +69     
- Misses       3837     3857      +20     
  Partials      793      793

@jackfrancis jackfrancis changed the title feat: add UDP Standard LB rule to enable outbound access fix: add UDP Standard LB rule to enable outbound access Apr 26, 2019
@jackfrancis
Copy link
Member Author

@ritazh can you kindly do a functional review? In a nutshell, in order to enable outbound UDP on masters + nodes in a standard LB-enabled cluster, that cluster will have the requirement of 4 external IP addresses, one each for UDP and TCP per LB (one LB for masters one LB for nodes).

I've confirmed that this PR fulfills the requirement of enabling TCP and UDP outbound (in particular, the obvious symptom this fixes is to enable ntp time sync on masters and nodes).

@ritazh
Copy link
Member

ritazh commented Apr 26, 2019

lgtm

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Apr 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 00bc995 into Azure:master Apr 26, 2019
@jackfrancis jackfrancis deleted the standard-lb-udp-outbound branch April 26, 2019 18:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants