This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
style: remove literal carriage returns and lint all shell scripts #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1148 +/- ##
=======================================
Coverage 74.43% 74.43%
=======================================
Files 131 131
Lines 18317 18317
=======================================
Hits 13634 13634
Misses 3902 3902
Partials 781 781 |
|
/override pr-e2e (k8s_1_12_release_e2e) Edit: d'oh. Note: ^^ this doesn't seem to work, just wanted to try the bot command. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Updates
scripts/validate-shell.shto lint all shell scripts in the system, but exempts the current set ofshellcheckcomplaints. This allows enforcement of only the rules we agree with across all thebashlogic.Also fixes SC1017 Literal carriage return. Run script through
tr -d '\r'.Issue Fixed:
Refs #953
Requirements:
Notes:
If this makes sense, I propose to trickle out such
bashfixes one-by-one over time, until AKS Engine is at a point where we are only ignoring specific linter issues by agreement.