Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Replace go-dev base image #264

Merged
merged 28 commits into from
Oct 22, 2024
Merged

Conversation

christinalau0
Copy link
Contributor

Reason for Change:

The go-dev base image was archived, its last update was for go 1.21: https://github.com/deis/docker-go-dev/blob/v1.39.1/rootfs/Dockerfile

This PR removes the use of go-dev base image, and instead uses the MAR go base image: https://mcr.microsoft.com/en-us/artifact/mar/oss/go/microsoft/golang/tags

In addition, this PR adds make targets to install azure cli, kubectl, k, azcopy, etc. The steps now are to use the MAR go base image, and then run make bootstrap.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@christinalau0
Copy link
Contributor Author

Successfully updated and validated:

  • ADO PR-E2E
  • ADO Test-Vhd-No-Egress
  • ADO AIB VHD

Updated but did NOT validate:

  • ADO marketplace
  • ADO windows scripts
  • Hub E2E

@christinalau0 christinalau0 merged commit 8122132 into Azure:master Oct 22, 2024
2 checks passed
@christinalau0 christinalau0 deleted the replace-go-dev branch October 22, 2024 22:26
@christinalau0 christinalau0 restored the replace-go-dev branch October 28, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants