Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Output AIB release notes and cgmanifest to customization.log #263

Merged
merged 4 commits into from
Oct 19, 2024

Conversation

christinalau0
Copy link
Contributor

Reason for Change:

  • This is a temporary mitigation to get VHD release notes and cgmanifest.json during AIB VHD pipeline.
    • Note that when the image builder resource group is created, it must be manually locked so that the AIB customization.log and storage account will not be deleted by AIB pipeline after successful image creation.
    • In the future, we should add a proper step to copy out the VHD release notes and cgmanifest.json.
  • Removed validation steps in release.yaml, these steps should be done by ADO pipelines (test vhd no egress and PR E2E) before triggering release.yaml.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@christinalau0
Copy link
Contributor Author

Validated with ADO AIB pipeline.

Copy link
Contributor

@JesusAlvarezTorres JesusAlvarezTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@christinalau0 christinalau0 merged commit 0b65001 into Azure:master Oct 19, 2024
2 checks passed
@christinalau0 christinalau0 deleted the aib-release-notes branch October 19, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants